unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#39637: mongo-tools test fail with Go 1.13
@ 2020-02-16 21:28 Jack Hill
  2020-02-17 15:54 ` Jack Hill
  2021-03-22 16:49 ` bug#39637: mongo-tool no longer in Guix, so the tests no longer fail Jack Hill
  0 siblings, 2 replies; 3+ messages in thread
From: Jack Hill @ 2020-02-16 21:28 UTC (permalink / raw)
  To: 39637

Hi Guix,

After the recent Go 1.13 update, the test for mongo-tools package 
(currently at vervsion 3.4.0) fails with:

```
flag provided but not defined: -test.testlogfile
Usage of /tmp/guix-build-mongo-tools-3.4.24.drv-0/go-build972699285/b001/mongofiles.test:
   -convey-json
         When true, emits results in JSON blocks. Default: 'false'
   -convey-silent
         When true, all output from GoConvey is suppressed.
   -convey-story
         When true, emits story output, otherwise emits dot output. When not provided, this flag mirros the value of the '-test.v' flag
   -test.types string
         Comma-separated list of the types of tests to be run (default "unit")
FAIL    github.com/mongodb/mongo-tools/mongofiles       0.002s
FAIL
command "go" "test" "-v" "github.com/mongodb/mongo-tools/mongofiles" failed with status 1
```

I believe that this is related to a change in Go's testing module with 
1.13: https://golang.org/doc/go1.13#testing

For more information, also see the Go bug report: 
https://github.com/golang/go/issues/31859

Note that mongo-tools provides a number of tools in different Go packages, 
and the mongofiles tool is the only one that has this error.

I have tried to adding a call to flag.Parse() in TestMain, which I added, 
as described in the documentation [0], but that did not resolve the 
problem. I'm not exactly sure why. The same fix worked for containerd [1].

[0] https://golang.org/pkg/testing/#hdr-Main
[1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=13c8e747e86e39c0a8c6ec7da8c812d9bbcb682b

I wonder if the difference is that mongofiles does not use the flag 
package directly, but flag.Parse() is being called in the wrong place in 
one of its dependencies.

A note on versions: the problem persists in the latest release of 
mongo-tools in the 3.4 series, 3.4.24. I have not tried the other release 
series, 3.6, 4.0, and 4.2 because those require dependencies not yet 
packaged in Guix.

I have opened a bug report upstream: 
https://jira.mongodb.org/browse/TOOLS-2482

Thoughts or suggestions?

Best,
Jack

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#39637: mongo-tools test fail with Go 1.13
  2020-02-16 21:28 bug#39637: mongo-tools test fail with Go 1.13 Jack Hill
@ 2020-02-17 15:54 ` Jack Hill
  2021-03-22 16:49 ` bug#39637: mongo-tool no longer in Guix, so the tests no longer fail Jack Hill
  1 sibling, 0 replies; 3+ messages in thread
From: Jack Hill @ 2020-02-17 15:54 UTC (permalink / raw)
  To: 39637

On Sun, 16 Feb 2020, Jack Hill wrote:

> I have opened a bug report upstream: 
> https://jira.mongodb.org/browse/TOOLS-2482

Upstream reports, "MongoDB 3.4 is now EOL so it is no longer supported. 
For MongoDB Tools specifically, we're only making critical fixes to 
versions <4.2." Therefore, it seems like the thing to do is to work on 
updating our mongo-tools package.

Best,
Jack

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#39637: mongo-tool no longer in Guix, so the tests no longer fail
  2020-02-16 21:28 bug#39637: mongo-tools test fail with Go 1.13 Jack Hill
  2020-02-17 15:54 ` Jack Hill
@ 2021-03-22 16:49 ` Jack Hill
  1 sibling, 0 replies; 3+ messages in thread
From: Jack Hill @ 2021-03-22 16:49 UTC (permalink / raw)
  To: 39637-done

mongo-tools was removed from Guix in commit 
097cf21d1d34f4f66a403c3fb6e15b6709c4dd8a so I'm closing this issue.

Best,
Jack




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-22 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16 21:28 bug#39637: mongo-tools test fail with Go 1.13 Jack Hill
2020-02-17 15:54 ` Jack Hill
2021-03-22 16:49 ` bug#39637: mongo-tool no longer in Guix, so the tests no longer fail Jack Hill

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).