* bug#19830: cannot use snippets with zip source
@ 2015-02-10 16:27 Ricardo Wurmus
2015-03-24 21:05 ` bug#19830: Bug #19830: " Eric Bavier
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Wurmus @ 2015-02-10 16:27 UTC (permalink / raw)
To: 19830
Snippets cannot be used when the source archive is not supported by tar.
For example, when building HISAT with snippets (instead of patching in a
build phase), guix determines the decompression type to be "xz" and then
fails as follows:
~~~~~~~
The following derivations will be built:
/gnu/store/jra0psbhjkcf66rdmj5bshivf32nyf73-hisat-0.1.4.drv
/gnu/store/1hpkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv
/gnu/store/pri51516agpcm9k6asgbdmspxnim3l7q-hisat-0.1.4.drv
@ build-started /gnu/store/1hpkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv - x86_64-linux /var/log/guix/drvs/1h//pkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv.bz2
/gnu/store/c4km8376y174q7gxqahf4hc1i1xaqkqh-tar-1.28/bin/tar: This does not look like a tar archive
/gnu/store/c4km8376y174q7gxqahf4hc1i1xaqkqh-tar-1.28/bin/tar: Skipping to next header
/gnu/store/c4km8376y174q7gxqahf4hc1i1xaqkqh-tar-1.28/bin/tar: Exiting with failure status due to previous errors
builder for `/gnu/store/1hpkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv' failed with exit code 1
@ build-failed /gnu/store/1hpkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv - 1 builder for `/gnu/store/1hpkf8yl4hcifzalnwh2hj6qwi8jid3w-hisat-0.1.4-beta-source.tar.xz.drv' failed with exit code 1
cannot build derivation `/gnu/store/pri51516agpcm9k6asgbdmspxnim3l7q-hisat-0.1.4.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/jra0psbhjkcf66rdmj5bshivf32nyf73-hisat-0.1.4.drv': 1 dependencies couldn't be built
killing process 2524
guix build: error: build failed: build of `/gnu/store/jra0psbhjkcf66rdmj5bshivf32nyf73-hisat-0.1.4.drv' failed
~~~~~~~
That's due to the definiton of `decompression-type' in
`patch-and-repack' in the file guix/packages.scm:
~~~~~~
(define decompression-type
(cond ((string-suffix? "gz" source-file-name) "gzip")
((string-suffix? "bz2" source-file-name) "bzip2")
((string-suffix? "lz" source-file-name) "lzip")
(else "xz")))
~~~~~~
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#19830: Bug #19830: cannot use snippets with zip source
2015-02-10 16:27 bug#19830: cannot use snippets with zip source Ricardo Wurmus
@ 2015-03-24 21:05 ` Eric Bavier
0 siblings, 0 replies; 2+ messages in thread
From: Eric Bavier @ 2015-03-24 21:05 UTC (permalink / raw)
To: 19830-close
Fixed in commit 17287d7d47567aa1649250182e0f7ab11d5d55d1.
--
`~Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-24 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-10 16:27 bug#19830: cannot use snippets with zip source Ricardo Wurmus
2015-03-24 21:05 ` bug#19830: Bug #19830: " Eric Bavier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).