* bug#47186: python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts @ 2021-03-16 8:32 Léo Le Bouter via Bug reports for GNU Guix 2021-03-17 8:05 ` Mark H Weaver 0 siblings, 1 reply; 3+ messages in thread From: Léo Le Bouter via Bug reports for GNU Guix @ 2021-03-16 8:32 UTC (permalink / raw) To: 47186 [-- Attachment #1: Type: text/plain, Size: 491 bytes --] As outlined by: - https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a01bfa7deed1d556fc75ab5588517442054bc5a9 - https://git.savannah.gnu.org/cgit/guix.git/commit/?id=db87d6ddafd26c5ad657178cf7fdab524d05c522 Two commits needed to be made to fix the issue both in the python2 and python3 variants, if the package-with-python2 and strip-python2-variant function could make so it inherits grafts it would make grafting python packages with python2 variants less "forget"-prone. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#47186: python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts 2021-03-16 8:32 bug#47186: python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts Léo Le Bouter via Bug reports for GNU Guix @ 2021-03-17 8:05 ` Mark H Weaver 2021-03-18 10:31 ` Léo Le Bouter via Bug reports for GNU Guix 0 siblings, 1 reply; 3+ messages in thread From: Mark H Weaver @ 2021-03-17 8:05 UTC (permalink / raw) To: Léo Le Bouter, 47186 Hi Léo, Léo Le Bouter via Bug reports for GNU Guix <bug-guix@gnu.org> writes: > As outlined by: > - > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a01bfa7deed1d556fc75ab5588517442054bc5a9 > - > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=db87d6ddafd26c5ad657178cf7fdab524d05c522 > > Two commits needed to be made to fix the issue both in the python2 and > python3 variants, if the package-with-python2 and strip-python2-variant > function could make so it inherits grafts it would make grafting python > packages with python2 variants less "forget"-prone. I've made an attempt to improve this situation in commit 1a265842e634656411bc7304c4648273f174f65e on the 'master' branch. Especially note the changes made in guix/build-system/python.scm. You might find that commit db87d6ddafd26c5ad657178cf7fdab524d05c522 is no longer needed. Would you like to check and report back? Thanks, Mark ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#47186: python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts 2021-03-17 8:05 ` Mark H Weaver @ 2021-03-18 10:31 ` Léo Le Bouter via Bug reports for GNU Guix 0 siblings, 0 replies; 3+ messages in thread From: Léo Le Bouter via Bug reports for GNU Guix @ 2021-03-18 10:31 UTC (permalink / raw) To: Mark H Weaver, 47186-done [-- Attachment #1: Type: text/plain, Size: 542 bytes --] On Wed, 2021-03-17 at 04:05 -0400, Mark H Weaver wrote: > I've made an attempt to improve this situation in commit > 1a265842e634656411bc7304c4648273f174f65e on the 'master' branch. > Especially note the changes made in guix/build-system/python.scm. > > You might find that commit db87d6ddafd26c5ad657178cf7fdab524d05c522 > is > no longer needed. Would you like to check and report back? > > Thanks, > Mark That worked, reverted python2-specific commit as 45695cc8a7b56b711baf664ceedaa66124d6de26. Thank you! [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-18 10:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-16 8:32 bug#47186: python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts Léo Le Bouter via Bug reports for GNU Guix 2021-03-17 8:05 ` Mark H Weaver 2021-03-18 10:31 ` Léo Le Bouter via Bug reports for GNU Guix
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).