unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#53329: Integrated keyboard doesn't work (Lenovo N22)
@ 2022-01-17 21:36 Jack Ridehalgh via Bug reports for GNU Guix
  2022-01-17 23:15 ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Jack Ridehalgh via Bug reports for GNU Guix @ 2022-01-17 21:36 UTC (permalink / raw)
  To: 53329

Hello,

Due to the bug mentioned here on the Nix tracker
(https://github.com/NixOS/nixpkgs/issues/143223) and elsewhere it is not
possible to use the integrated keyboard on some Braswell laptops.

Would it be possible to include CONFIG_PINCTRL_CHERRYVIEW=y in the kernel
configuration so the keyboard functions correctly on these machines?
Sadly the kernel module does not work when trying to load via modprobe
and these machines are so low powered it's difficult to compile my own kernel.

Many thanks,
Jack




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#53329: Integrated keyboard doesn't work (Lenovo N22)
  2022-01-17 21:36 bug#53329: Integrated keyboard doesn't work (Lenovo N22) Jack Ridehalgh via Bug reports for GNU Guix
@ 2022-01-17 23:15 ` Leo Famulari
  2022-01-18  2:29   ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2022-01-17 23:15 UTC (permalink / raw)
  To: 53329

On Mon, Jan 17, 2022 at 09:36:55PM +0000, Jack Ridehalgh via Bug reports for GNU Guix wrote:
> Due to the bug mentioned here on the Nix tracker
> (https://github.com/NixOS/nixpkgs/issues/143223) and elsewhere it is not
> possible to use the integrated keyboard on some Braswell laptops.

Thanks for bringing this report to Guix. There is also this discussion
upstream:

https://bugzilla.kernel.org/show_bug.cgi?id=194945

The upstream bug report suggests that this functionality worked until
Linux 4.9. Could you try with linux-libre-4.4? We have it packaged. I
don't recommend planning to stick with 4.4, but it would be interesting
as a test.

> Would it be possible to include CONFIG_PINCTRL_CHERRYVIEW=y in the kernel
> configuration so the keyboard functions correctly on these machines?

Yes, we can do that.

As shown here, this model is currently built as a module, although the
Bay Trail pinctrl stuff is built-in:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf?id=2c7f2b40e2dbee48075147a87c6cd9b611dc5ba9#n4704

It's been like that for several years.

> Sadly the kernel module does not work when trying to load via modprobe
> and these machines are so low powered it's difficult to compile my own kernel.

As the upstream discussion says, it would be great to understand why
this stuff doesn't work when built as a module. But, Debian builds all
of them into the kernel, and there must be a reason for that.

I'll make a Git branch in our repo that you can pull from to test the
fix.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#53329: Integrated keyboard doesn't work (Lenovo N22)
  2022-01-17 23:15 ` Leo Famulari
@ 2022-01-18  2:29   ` Leo Famulari
  2022-01-18 23:39     ` Jack Ridehalgh via Bug reports for GNU Guix
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2022-01-18  2:29 UTC (permalink / raw)
  To: 53329

On Mon, Jan 17, 2022 at 06:15:50PM -0500, Leo Famulari wrote:
> I'll make a Git branch in our repo that you can pull from to test the
> fix.

Try pulling from the wip-fix-53329 branch and reconfiguring your system
based on that. I've arranged to have a substitute for the x86_64 kernel
on that branch.

`guix pull --branch=wip-fix-53329 && guix system reconfigure ...`

https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-fix-53329 




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#53329: Integrated keyboard doesn't work (Lenovo N22)
  2022-01-18  2:29   ` Leo Famulari
@ 2022-01-18 23:39     ` Jack Ridehalgh via Bug reports for GNU Guix
  2022-01-19  1:34       ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Jack Ridehalgh via Bug reports for GNU Guix @ 2022-01-18 23:39 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 53329

[-- Attachment #1: Type: text/html, Size: 1401 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#53329: Integrated keyboard doesn't work (Lenovo N22)
  2022-01-18 23:39     ` Jack Ridehalgh via Bug reports for GNU Guix
@ 2022-01-19  1:34       ` Leo Famulari
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2022-01-19  1:34 UTC (permalink / raw)
  To: Jack Ridehalgh; +Cc: 53329-done

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

On Tue, Jan 18, 2022 at 11:39:14PM +0000, Jack Ridehalgh wrote:
> 
> I can confirm the built-in kernel module in branch wip-fix-53329 has fixed the
> keyboard issue on my laptop. With regards to trying 4.4-lts, I would get a
> black screen on boot so I couldn't test that.

Great! I've deployed the fix on the "master branch", so you should get
it by default the next time you pull and reconfigure.

You might get a warning from `guix pull` about "downgrades" the next
time you pull, since the wip-fix-53329 branch forked off the main
branch... not sure. Anyways, it's safe to use --allow-downgrades this
time, if necessary. Check here for a reference on the subject:

https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-pull.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-01-19  1:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 21:36 bug#53329: Integrated keyboard doesn't work (Lenovo N22) Jack Ridehalgh via Bug reports for GNU Guix
2022-01-17 23:15 ` Leo Famulari
2022-01-18  2:29   ` Leo Famulari
2022-01-18 23:39     ` Jack Ridehalgh via Bug reports for GNU Guix
2022-01-19  1:34       ` Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).