bug#47020: debug output of -boot0 packages is probably unneeded

bug#47020: debug output of -boot0 packages is probably unneeded

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

Some packages we probably don't need to automatically create debug
outputs for. We could probably drop the debug outputs for all the
packages that have them in commencement except for the -final ones.

(ins)efraim@3900XT ~/workspace/guix$ du -sch \
/gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0 \
/gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib \
/gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
95M     /gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0
11M     /gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib
323M    /gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
429M    total

short list:
gnu-make-boot0
coreutils-boot0
gcc-boot0
glibc-final-with-bootstrap-bash (maybe)

we can then also adjust the outputs of gcc-final to not delete the debug
output of gcc-boot0, which it inherits from.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#47020: [PATCH 1/4] gnu: gnu-make-boot0: Don't include debug output.

[Efraim Flashner]

* gnu/packages/commencement.scm (gnu-make-boot0)[outputs]: Remove debug
from inherited outputs.
---
 gnu/packages/commencement.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 890d57941f..07d657ce15 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -2403,6 +2403,7 @@ exec " gcc "/bin/" program
 (define gnu-make-boot0
   (package
     (inherit gnu-make)
+    (outputs (delete "debug" (package-outputs gnu-make)))
     (source (bootstrap-origin (package-source gnu-make)))
     (name "make-boot0")
     (arguments
-- 
2.30.1

bug#47020: [PATCH 2/4] gnu: coreutils-boot0: Don't include debug output.

[Efraim Flashner]

* gnu/packages/commencement.scm (coreutils-boot0)[outputs]: Remove debug
from inherited outputs.
---
 gnu/packages/commencement.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 07d657ce15..08538dbe5d 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -2446,6 +2446,7 @@ exec " gcc "/bin/" program
 (define coreutils-boot0
   (package
     (inherit coreutils)
+    (outputs (delete "debug" (package-outputs coreutils)))
     (source (bootstrap-origin (package-source coreutils)))
     (name "coreutils-boot0")
     (native-inputs `())
-- 
2.30.1

bug#47020: [PATCH 3/4] gnu: gcc-boot0: Don't include debug output.

[Efraim Flashner]

* gnu/packages/commencement.scm (gcc-boot0)[outputs]: Remove debug
from inherited outputs.
---
 gnu/packages/commencement.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 08538dbe5d..9ca5bc4a7e 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -2707,6 +2707,7 @@ exec " gcc "/bin/" program
   (package
     (inherit gcc)
     (name "gcc-cross-boot0")
+    (outputs (delete "debug" (package-outputs gcc)))
     (source (bootstrap-origin (package-source gcc)))
     (arguments
      `(#:guile ,%bootstrap-guile
-- 
2.30.1

bug#47020: [PATCH 4/4] gnu: glibc-final-with-bootstrap-bash-boot0: Don't include debug output.

[Efraim Flashner]

* gnu/packages/commencement.scm (glibc-final-with-bootstrap-bash-boot0)
[outputs]: Remove debug from inherited outputs.
---
 gnu/packages/commencement.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 9ca5bc4a7e..b2921a4a48 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -3180,6 +3180,7 @@ memoized as a function of '%current-system'."
   (package
     (inherit glibc)
     (name "glibc-intermediate")
+    (outputs (delete "debug" (package-outputs glibc)))
     (source (bootstrap-origin (package-source glibc)))
     (arguments
      `(#:guile ,%bootstrap-guile
-- 
2.30.1

bug#47020: debug output of -boot0 packages is probably unneeded

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> Some packages we probably don't need to automatically create debug
> outputs for. We could probably drop the debug outputs for all the
> packages that have them in commencement except for the -final ones.
>
> (ins)efraim@3900XT ~/workspace/guix$ du -sch \
> /gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0 \
> /gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib \
> /gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
> 95M     /gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0
> 11M     /gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib
> 323M    /gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
> 429M    total
>
> short list:
> gnu-make-boot0
> coreutils-boot0
> gcc-boot0
> glibc-final-with-bootstrap-bash (maybe)
>
> we can then also adjust the outputs of gcc-final to not delete the debug
> output of gcc-boot0, which it inherits from.

+1 on removing the “debug” output from there (while making sure we don’t
inadvertently remove it from the “final” variants!).

Ludo’.

bug#47020: debug output of -boot0 packages is probably unneeded

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Wed, Mar 10, 2021 at 12:26:46PM +0100, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > Some packages we probably don't need to automatically create debug
> > outputs for. We could probably drop the debug outputs for all the
> > packages that have them in commencement except for the -final ones.
> >
> > (ins)efraim@3900XT ~/workspace/guix$ du -sch \
> > /gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0 \
> > /gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib \
> > /gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
> > 95M     /gnu/store/4qn544j2a062s5kbj1bfxbak060zbq4k-gcc-cross-boot0-7.5.0
> > 11M     /gnu/store/vx0x26r5q7z99rih8k1mxyf2bih3vnpc-gcc-cross-boot0-7.5.0-lib
> > 323M    /gnu/store/nbg9qafs2x24bj7lm7km4wg2bfjsp64f-gcc-cross-boot0-7.5.0-debug
> > 429M    total
> >
> > short list:
> > gnu-make-boot0
> > coreutils-boot0
> > gcc-boot0
> > glibc-final-with-bootstrap-bash (maybe)
> >
> > we can then also adjust the outputs of gcc-final to not delete the debug
> > output of gcc-boot0, which it inherits from.
> 
> +1 on removing the “debug” output from there (while making sure we don’t
> inadvertently remove it from the “final” variants!).
> 

Done. Patches pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#47020: [PATCH 1/4] gnu: gnu-make-boot0: Don't include debug output.

[Ludovic Courtès]

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/commencement.scm (gnu-make-boot0)[outputs]: Remove debug
> from inherited outputs.

Make sure nothing inherits from these packages, in which case we might
inadvertently override ‘outputs’ in those packages too.

Otherwise this and the subsequent patches LGTM!

Thanks,
Ludo’.

bug#47020: [PATCH 1/4] gnu: gnu-make-boot0: Don't include debug output.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

On Thu, Mar 18, 2021 at 10:26:27PM +0100, Ludovic Courtès wrote:
> Hi Efraim,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > * gnu/packages/commencement.scm (gnu-make-boot0)[outputs]: Remove debug
> > from inherited outputs.
> 
> Make sure nothing inherits from these packages, in which case we might
> inadvertently override ‘outputs’ in those packages too.
> 
> Otherwise this and the subsequent patches LGTM!
> 
> Thanks,
> Ludo’.

Thanks. gcc-final inherits from gcc-boot0, but it already deleted the
debug output.

Patches pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]