unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#64074: guix [COMMAND] --load-path does not check if path is valid
@ 2023-06-14 22:47 Christian Miller via Bug reports for GNU Guix
  2023-06-15 12:39 ` Ludovic Courtès
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Christian Miller via Bug reports for GNU Guix @ 2023-06-14 22:47 UTC (permalink / raw)
  To: 64074

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

User can set load path with -L or --load-path in commands like guix build, guix time-machine and so on. But this flag does not check if the path is actually a valid directory. You can point to a directory that doesn't even exist on the filesystem. It should do that just like the -f or --file flag for the guilx build command.

[-- Attachment #2: Type: text/html, Size: 437 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#64074: guix [COMMAND] --load-path does not check if path is valid
  2023-06-14 22:47 bug#64074: guix [COMMAND] --load-path does not check if path is valid Christian Miller via Bug reports for GNU Guix
@ 2023-06-15 12:39 ` Ludovic Courtès
  2023-06-16 18:19 ` Christian Miller via Bug reports for GNU Guix
  2023-06-28 14:40 ` Christian Miller via Bug reports for GNU Guix
  2 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-06-15 12:39 UTC (permalink / raw)
  To: Christian Miller; +Cc: 64074

Hi,

Christian Miller <miller.christian@proton.me> skribis:

> User can set load path with -L or --load-path in commands like guix
> build, guix time-machine and so on. But this flag does not check if
> the path is actually a valid directory. You can point to a directory
> that doesn't even exist on the filesystem.

Indeed.  That’s the same for all similar search path command-line flags
(think ‘gcc -I…’, ‘ld -L…’, and so on).

> It should do that just like the -f or --file flag for the guilx build
> command.

I don’t think so; I think tolerating non-existent directories in the
search path is useful.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#64074: guix [COMMAND] --load-path does not check if path is valid
  2023-06-14 22:47 bug#64074: guix [COMMAND] --load-path does not check if path is valid Christian Miller via Bug reports for GNU Guix
  2023-06-15 12:39 ` Ludovic Courtès
@ 2023-06-16 18:19 ` Christian Miller via Bug reports for GNU Guix
  2023-06-16 22:22   ` Csepp
  2023-06-28 14:40 ` Christian Miller via Bug reports for GNU Guix
  2 siblings, 1 reply; 5+ messages in thread
From: Christian Miller via Bug reports for GNU Guix @ 2023-06-16 18:19 UTC (permalink / raw)
  To: 64074@debbugs.gnu.org

Hello,

well in that case, if it is consistent with other GNU tools, it makes sense and this can be closed.  Though before closing, do you may have an example for invalid paths that could be useful?

Best Regards
Christian Miller




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#64074: guix [COMMAND] --load-path does not check if path is valid
  2023-06-16 18:19 ` Christian Miller via Bug reports for GNU Guix
@ 2023-06-16 22:22   ` Csepp
  0 siblings, 0 replies; 5+ messages in thread
From: Csepp @ 2023-06-16 22:22 UTC (permalink / raw)
  To: Christian Miller; +Cc: 64074


Christian Miller via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

> Hello,
>
> well in that case, if it is consistent with other GNU tools, it makes
> sense and this can be closed.  Though before closing, do you may have
> an example for invalid paths that could be useful?
>
> Best Regards
> Christian Miller

If I add ~/.local/bin to my $PATH and then delete that directory, I
don't want my shell to abort with an error.
I've also seen configure scripts add /usr/include, which doesn't exist
on Guix.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#64074: guix [COMMAND] --load-path does not check if path is valid
  2023-06-14 22:47 bug#64074: guix [COMMAND] --load-path does not check if path is valid Christian Miller via Bug reports for GNU Guix
  2023-06-15 12:39 ` Ludovic Courtès
  2023-06-16 18:19 ` Christian Miller via Bug reports for GNU Guix
@ 2023-06-28 14:40 ` Christian Miller via Bug reports for GNU Guix
  2 siblings, 0 replies; 5+ messages in thread
From: Christian Miller via Bug reports for GNU Guix @ 2023-06-28 14:40 UTC (permalink / raw)
  To: 64074-done@debbugs.gnu.org

Since this behavior is consistent with other GNU tools and my question has been answered, I close the issue.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-28 14:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 22:47 bug#64074: guix [COMMAND] --load-path does not check if path is valid Christian Miller via Bug reports for GNU Guix
2023-06-15 12:39 ` Ludovic Courtès
2023-06-16 18:19 ` Christian Miller via Bug reports for GNU Guix
2023-06-16 22:22   ` Csepp
2023-06-28 14:40 ` Christian Miller via Bug reports for GNU Guix

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).