bug#35743: guix import hackage wai-app-static fails (comment syntax?)

bug#35743: guix import hackage wai-app-static fails (comment syntax?)

[Robert Vollmert]

$ guix import hackage wai-app-static
Syntax error: unexpected token : (ghc-options (-Wall)) (at line 106, column 2)

The relevant extract of the cabal file is:

test-suite runtests
[…]
    build-depends:   base                      >= 4        && < 5
[…]
                   , mockery
                   -- , containers
  ghc-options:   -Wall

Presumably the double dash comment is tripping `guix import` up.

bug#35743: indentation error

[Robert Vollmert]

I learned about `guix import hackage --stdin`, and it turns out the problem is with bad indentation in the cabal file. (The offending line is indented by two spaces instead of four spaces for the block before.) It’s unclear to me whether this is a “valid” cabal file as it is.

bug#35743: fixed upstream

[Robert Vollmert]

This specific case has been fixed upstream, and should eventually
make it to hackage:

https://github.com/yesodweb/wai/pull/748

The issue does remain in the sense that `guix import` doesn’t parse
some such cabal files that `cabal` is happy with — mark done anyway?

bug#35743: applies more widely

[Robert Vollmert]

The problem seems more wide-spread, so should probably be fixed within import/cabal.scm.

E.g. warp:

http://hackage.haskell.org/package/warp-3.2.27/warp.cabal
http://hackage.haskell.org/package/streaming-commons-0.2.1.0/streaming-commons.cabal

contain things along the following lines:

benchmark builder-to-bytestring-io
    ...
    build-depends:  base
                  , bytestring >= 0.10.2
                  , gauge
                  , deepseq
                  , streaming-commons

  if flag(use-bytestring-builder)
    build-depends:     bytestring < 0.10.2.0
                     , bytestring-builder

This kind of out-dented conditional seems not very rare.

bug#35743: guix import hackage: fails with mixed indentation

[Lars-Dominik Braun]

Hi,

> http://hackage.haskell.org/package/warp-3.2.27/warp.cabal
> http://hackage.haskell.org/package/streaming-commons-0.2.1.0/streaming-commons.cabal
> 
> contain things along the following lines:

these should be fixed by the patch in #67564.

Cheers,
Lars