From: Julien Lepiller <julien@lepiller.eu>
To: raingloom@riseup.net, 58112@debbugs.gnu.org
Subject: bug#58112: OPAM importer fails in lookup-node
Date: Tue, 27 Sep 2022 17:42:06 +0200 [thread overview]
Message-ID: <DEAED6AB-EDFF-4A83-9435-90FA9E6A6C35@lepiller.eu> (raw)
In-Reply-To: <87sfkd11eh.fsf@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
It's probably because other importers are structured that way. I'd be in favor of changing that and using the condition system.
Le 27 septembre 2022 13:33:56 GMT+02:00, Csepp <raingloom@riseup.net> a écrit :
>The specific error is this:
>Wrong number of values returned to continuation (expected 2)
>It is caused by opam->guix-package silencing intermediate errors by
>using and-let* (the poor person's Maybe monad) and returning #f when the
>receiving side expects two return values.
>
>Initial reproducer:
>guix import opam -r mirage
>
>Also happens with opam-monorepo.
>
>Cc-ing Julien whom might know why the code is structured this way? It's
>not like the calling side can handle a falsy return and the error is not
>detected early either, so the user doesn't even know what is causing it.
>Can I just turn it all into errors? Or maybe we can use the condition
>system?
>
[-- Attachment #2: Type: text/html, Size: 1181 bytes --]
prev parent reply other threads:[~2022-09-27 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:33 bug#58112: OPAM importer fails in lookup-node Csepp
2022-09-27 13:47 ` zimoun
2022-09-27 15:42 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEAED6AB-EDFF-4A83-9435-90FA9E6A6C35@lepiller.eu \
--to=julien@lepiller.eu \
--cc=58112@debbugs.gnu.org \
--cc=raingloom@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).