From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0DqgGIUdM2OkHgEAbAwnHQ (envelope-from ) for ; Tue, 27 Sep 2022 17:57:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6NeaGIUdM2MW9wAAauVa8A (envelope-from ) for ; Tue, 27 Sep 2022 17:57:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B85310646 for ; Tue, 27 Sep 2022 17:57:56 +0200 (CEST) Received: from localhost ([::1]:42620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odCy3-0001mK-1s for larch@yhetil.org; Tue, 27 Sep 2022 11:57:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCkc-0002AK-JI for bug-guix@gnu.org; Tue, 27 Sep 2022 11:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odCkc-0007Rt-Be for bug-guix@gnu.org; Tue, 27 Sep 2022 11:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odCkc-0002rz-7A for bug-guix@gnu.org; Tue, 27 Sep 2022 11:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58112: OPAM importer fails in lookup-node Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 27 Sep 2022 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58112 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: raingloom@riseup.net, 58112@debbugs.gnu.org X-Debbugs-Original-To: Csepp , Bug reports for GNU Guix Received: via spool by submit@debbugs.gnu.org id=B.166429340510973 (code B ref -1); Tue, 27 Sep 2022 15:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Sep 2022 15:43:25 +0000 Received: from localhost ([127.0.0.1]:56584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCk1-0002qu-3J for submit@debbugs.gnu.org; Tue, 27 Sep 2022 11:43:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:52188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCjz-0002qo-FF for submit@debbugs.gnu.org; Tue, 27 Sep 2022 11:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCjx-0000sp-9D for bug-guix@gnu.org; Tue, 27 Sep 2022 11:43:23 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:44804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCju-000731-PW for bug-guix@gnu.org; Tue, 27 Sep 2022 11:43:21 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 9a7f76f1; Tue, 27 Sep 2022 15:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=kGHQA2SLKB3c Kn75Nh+QBUQjtv0JqZ9mptqI+wVRJGM=; b=nqZLDIdEcs5127EYc6ahHKLHYAY5 6dypy0leg4NE+rWiy//+oltpkZtIB0NHl9KC9C8f5AmE0Rngb27IBikQstPTmd7O q2i32rAbeoB7hVR3Q4DEq5XdrFW0jYbN5GHT4vjoXaYxVf0tF/FFUoVeD4vtT8GM NHwGBqUztXdVlTuDNSHKv5AEMkNkyZNlQz8ejcm06KhpfUA/AC9wdIyh3Bfh//Iq MSYVILpw4hA2HJgEPrzaoq3IN7EfFc5Iu5ji/vrKJ+Rvceb9WaRNb0YqMSegUhgB OkcCY9Ajyn0e558y7+FIx2KDslDkfbQ0u5XUJo+gfbp0xxfqpnBwSQMtwA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id a382e312 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 27 Sep 2022 15:42:08 +0000 (UTC) Date: Tue, 27 Sep 2022 17:42:06 +0200 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <87sfkd11eh.fsf@riseup.net> References: <87sfkd11eh.fsf@riseup.net> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664294277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wvF3HrNb/VB134QWTZJktBfbNJ82tw/0qUAovoRfrpw=; b=fK2lWqX2taJF2RZTFZKYz0LPDyAI/49Nv2nI3LP9We0/Qi0xT3V1Om+NMOI51Pc9xRYCes dcc75W89bbsS/43Lr4LjBvPiWBaWRv2HP/x5w4Yy4vCuXCki9aRojkfhvOUc0zs1ntzTQB BxhW9l57IF0jocOHjIPVbqEcQI57+F7GyhbXBIaqO0yfbY5lFk0heWV2oR4N9nx5yqx6tS tbq1ZII/VbuS3tNlhP3L2zIDHccum7AQmOj2mW8qWubTndqLfaYMhG32stuH6TW/7iYMPZ SkckY+zfsXEJf6Hdwo4yjQfrsCHrF+wiA/O2MkEKkhE8oGlbiGNhwsnxhf3HOA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664294277; a=rsa-sha256; cv=none; b=VCqZfRWOD5AwRUKIEfOjZ8onbXo498n7KVLxf7hYV3SPHBKK70hqplCbz1ScEKKbhbiBFA 2vOOTquZAkoI6HFKdHUk8FRajfwb7bXiv1xCHkaXNPZAsu+CuALiUgWFcEzI2y2ebe8W3G YIWOT1h3dXbh+Tprou98lZVF917DM195p+lSnTIkUdoezBK9xeWe2FRxOZWUoCJKZDjFiJ ZdzqTB/Eap0MbWI3amU+cPo/pFUzBBqMKdOmrWU9BgwflFgyO0UV6mt5hJqoMzF5oJLZrQ Wc91ijU9eRKVsenVyPaIsQuGymwZgbms3sCUOtB5DK1J1TW/93p5kIReVMH2Tw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=nqZLDIdE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=nqZLDIdE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2B85310646 X-Spam-Score: 6.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1FWEMEHnsBPU ------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It's probably because other importers are structured that way=2E I'd be in = favor of changing that and using the condition system=2E Le 27 septembre 2022 13:33:56 GMT+02:00, Csepp a = =C3=A9crit=C2=A0: >The specific error is this: >Wrong number of values returned to continuation (expected 2) >It is caused by opam->guix-package silencing intermediate errors by >using and-let* (the poor person's Maybe monad) and returning #f when the >receiving side expects two return values=2E > >Initial reproducer: >guix import opam -r mirage > >Also happens with opam-monorepo=2E > >Cc-ing Julien whom might know why the code is structured this way? It's >not like the calling side can handle a falsy return and the error is not >detected early either, so the user doesn't even know what is causing it= =2E >Can I just turn it all into errors? Or maybe we can use the condition >system? > ------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable It's probably because other importers are structur= ed that way=2E I'd be in favor of changing that and using the condition sys= tem=2E

Le 27 septembre 2022 13:33:56 GMT+= 02:00, Csepp <raingloom@riseup=2Enet> a =C3=A9crit=C2=A0:
The specific error is this:
Wrong nu=
mber of values returned to continuation (expected 2)
It is caused by opa=
m->guix-package silencing intermediate errors by
using and-let* (the =
poor person's Maybe monad) and returning #f when the
receiving side expe=
cts two return values=2E

Initial reproducer:
guix import opam -r =
mirage

Also happens with opam-monorepo=2E

Cc-ing Julien whom =
might know why the code is structured this way?  It's
not like the calli=
ng side can handle a falsy return and the error is not
detected early ei=
ther, so the user doesn't even know what is causing it=2E
Can I just tur=
n it all into errors?  Or maybe we can use the condition
system?

=
------G48S72FG81P3ZS3LK4I6ZJPTS8TSBL--