From: zimoun <zimon.toutoune@gmail.com>
To: 39885@debbugs.gnu.org, me@tobias.gr, rekado@elephly.net
Subject: bug#39885: Bioconductor URI, fallback and time-machine
Date: Tue, 3 Mar 2020 16:59:03 +0100 [thread overview]
Message-ID: <CAJ3okZ3dFunYgafRH6=9LsLKLf6OrZBpXqUMxZAjEhaiL93ARA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
Dear,
Currently, the URI scheme (see 'bioconductor-uri' in
guix/build-system/r.scm) is:
https://bioconductor.org/packages/release/data/<type-url-part>/src/contrib/<upstream-name>-<version>.tar.gz
which leads to 2 issues:
1. when Bioconductor updates their release, some package versions are
updated too, and so, the upstream return 404.
2. for this reason 1., the "guix time-machine" is broken for all the
Bioconductor packages, at least if Berlin or SWH does not have a
substitute; which is not expected for 'annotation' packages.
However, the Bioconductor archive still serves the old release, i.e.,
https://bioconductor.org/packages/3.x/data/<type-url-part>/src/contrib/<upstream-name>-<version>.tar.gz
The ways to fix the both issues are:
a) Add the Bioconductor release (known at packaging time) to all the
packages; provide as argument to 'bioconductor-uri'.
b) Add more URLs to fallback.
As discussed on IRC, Tobias seems more inclined with the option a) and
I am more in favour of option b.
Attached, a quick patch showing the option b).
Please also consider #36805 which was never merged or closed.
http://issues.guix.gnu.org/issue/36805
All the best,
simon
[-- Attachment #2: 0001-build-system-r-Use-Bioconductor-old-releases-to-fall.patch --]
[-- Type: text/x-patch, Size: 2041 bytes --]
From 87e73e02202fe5e342d68f1fb17efdd4425737cd Mon Sep 17 00:00:00 2001
From: zimoun <zimon.toutoune@gmail.com>
Date: Tue, 3 Mar 2020 16:53:39 +0100
Subject: [PATCH] build-system: r: Use Bioconductor old releases to fallback.
* guix/build-system/r.scm (bioconductor-uri): Extend the fallback list.
---
guix/build-system/r.scm | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/guix/build-system/r.scm b/guix/build-system/r.scm
index 2d328764b0..8638e1b888 100644
--- a/guix/build-system/r.scm
+++ b/guix/build-system/r.scm
@@ -54,15 +54,18 @@ release corresponding to NAME and VERSION."
('annotation "/data/annotation")
('experiment "/data/experiment")
(_ "/bioc"))))
- (list (string-append "https://bioconductor.org/packages/release"
- type-url-part
- "/src/contrib/"
- name "_" version ".tar.gz")
- ;; TODO: use %bioconductor-version from (guix import cran)
- (string-append "https://bioconductor.org/packages/3.10"
- type-url-part
- "/src/contrib/Archive/"
- name "_" version ".tar.gz"))))
+ (append (list (string-append "https://bioconductor.org/packages/release"
+ type-url-part
+ "/src/contrib/"
+ name "_" version ".tar.gz"))
+ (map (lambda (release)
+ (string-append "https://bioconductor.org/packages/"
+ release
+ type-url-part
+ "/src/contrib/"
+ name "_" version ".tar.gz"))
+ (list (@@ (guix import cran) %bioconductor-version)
+ "3.9" "3.8" "3.7")))))
(define %r-build-system-modules
;; Build-side modules imported by default.
--
2.25.0
next reply other threads:[~2020-03-03 16:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 15:59 zimoun [this message]
2020-03-23 21:20 ` bug#39885: Bioconductor URI, fallback and time-machine Ricardo Wurmus
2020-05-21 23:29 ` zimoun
2020-06-24 11:07 ` zimoun
2020-06-28 20:14 ` Ludovic Courtès
2020-06-29 17:36 ` zimoun
2020-06-29 20:42 ` Ludovic Courtès
2020-11-19 14:22 ` zimoun
2021-11-22 19:48 ` zimoun
2022-07-18 16:03 ` zimoun
2022-07-18 16:21 ` Ricardo Wurmus
2022-08-10 18:25 ` Ricardo Wurmus
2022-08-10 19:44 ` Maxime Devos
2022-08-10 19:48 ` Maxime Devos
2022-09-09 17:23 ` zimoun
2024-01-08 15:07 ` Ludovic Courtès
2024-01-08 15:34 ` Ricardo Wurmus
2024-01-11 16:11 ` Simon Tournier
2023-12-22 13:40 ` bug#39885: Bioconductor tarballs are not archived Ludovic Courtès
2024-01-08 9:09 ` Simon Tournier
2024-01-08 15:02 ` Ludovic Courtès
2024-01-10 12:41 ` Ricardo Wurmus
2024-01-10 15:23 ` Simon Tournier
2024-01-19 15:46 ` Timothy Sample
2024-01-23 9:10 ` Ludovic Courtès
2024-02-14 15:23 ` Simon Tournier
2024-02-16 16:14 ` Timothy Sample
2024-02-19 16:50 ` Simon Tournier
2024-02-21 18:16 ` Timothy Sample
2023-12-22 20:57 ` bug#39885: Bioconductor URI, fallback and time-machine Ludovic Courtès
2024-01-02 9:20 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ3dFunYgafRH6=9LsLKLf6OrZBpXqUMxZAjEhaiL93ARA@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=39885@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).