unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Calvin Heim <frofroggy@gmail.com>, 38940@debbugs.gnu.org
Subject: bug#38940: \x1b]8; ; OSC character displayed on hyperlinks shown after calls to `guix describe` or `guix show` on mate-terminal 1.12.1 (Trisquel 8)
Date: Thu, 9 Jan 2020 22:31:10 +0100	[thread overview]
Message-ID: <CAJ3okZ1C6RN2OOXde1ta=qpDkYRmyrga2drXgEqOqaLi=Vdf=g@mail.gmail.com> (raw)
In-Reply-To: <87woa0tjbv.fsf@gnu.org>

Hi Ludo,

On Thu, 9 Jan 2020 at 22:23, Ludovic Courtès <ludo@gnu.org> wrote:

> > 1. Instead of INSIDE_EMACS, the variable name NO_SUPPORT_HYPERLINK or
> > other seems more meaningful. Maybe?
>
> Actually the goal was to remove ‘INSIDE_EMACS’ from there once a
> widespread-enough Emacs version supports it, which could be within a
> year.  And since other terminals are supposed to ignore it altogether, I
> would rather not add a special environment variable.

Sound reasonable. :-)


> > 2. The comment should go in the docstring.
>
> I tend to write “implementation details” as comments, while keeping pure
> descriptions of the interface as docstrings; I think it’s OK.  :-)

I fully trust your experience. ;-)


Cheers,
simon

  reply	other threads:[~2020-01-09 21:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-05  6:48 bug#38940: \x1b]8; ; OSC character displayed on hyperlinks shown after calls to `guix describe` or `guix show` on mate-terminal 1.12.1 (Trisquel 8) Calvin Heim
2020-01-06 18:37 ` zimoun
2020-01-06 20:26   ` Calvin Heim
2020-01-07 11:58     ` zimoun
2020-01-08  9:26       ` Calvin Heim
2020-01-08 21:28         ` Ludovic Courtès
2020-01-08 22:54           ` Calvin Heim
2020-01-09 12:09             ` zimoun
2020-01-09 21:24             ` Ludovic Courtès
2020-01-09 12:17           ` zimoun
2020-01-09 21:23             ` Ludovic Courtès
2020-01-09 21:31               ` zimoun [this message]
2020-01-10  3:16               ` Jack Hill
2020-01-10 13:51                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ1C6RN2OOXde1ta=qpDkYRmyrga2drXgEqOqaLi=Vdf=g@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=38940@debbugs.gnu.org \
    --cc=frofroggy@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).