From mboxrd@z Thu Jan  1 00:00:00 1970
From: zimoun <zimon.toutoune@gmail.com>
Subject: bug#38940: \x1b]8; ;
 OSC character displayed on hyperlinks shown after calls to `guix
 describe` or `guix show` on mate-terminal 1.12.1 (Trisquel 8)
Date: Thu, 9 Jan 2020 22:31:10 +0100
Message-ID: <CAJ3okZ1C6RN2OOXde1ta=qpDkYRmyrga2drXgEqOqaLi=Vdf=g@mail.gmail.com>
References: <1578206891.2605.33.camel@gmail.com>
 <CAJ3okZ3Rso90gqLknkcZd3j=uyNFU5B_=vwuJ47eXfyTX-nr=A@mail.gmail.com>
 <1578342380.2215.13.camel@gmail.com>
 <CAJ3okZ0xigUV3offJrTqVnXcgB_=1XevdL7f3wxz15=cwy_0+w@mail.gmail.com>
 <1578475589.2665.55.camel@gmail.com> <877e21eiy9.fsf@gnu.org>
 <CAJ3okZ0VPZRL+ZXq5MssmyrZD2z-zqJZJc7_1A_vHSxjfzRWRQ@mail.gmail.com>
 <87woa0tjbv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:40519)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfPP-000697-2D
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:32:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfPO-0008OD-0f
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:32:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47196)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ipfPN-0008Mn-Qq
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:32:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfPN-0002dg-Mg
 for bug-guix@gnu.org; Thu, 09 Jan 2020 16:32:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38940.B38940.15786054888757@debbugs.gnu.org>
In-Reply-To: <87woa0tjbv.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Calvin Heim <frofroggy@gmail.com>, 38940@debbugs.gnu.org

Hi Ludo,

On Thu, 9 Jan 2020 at 22:23, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:

> > 1. Instead of INSIDE_EMACS, the variable name NO_SUPPORT_HYPERLINK or
> > other seems more meaningful. Maybe?
>
> Actually the goal was to remove =E2=80=98INSIDE_EMACS=E2=80=99 from there=
 once a
> widespread-enough Emacs version supports it, which could be within a
> year.  And since other terminals are supposed to ignore it altogether, I
> would rather not add a special environment variable.

Sound reasonable. :-)


> > 2. The comment should go in the docstring.
>
> I tend to write =E2=80=9Cimplementation details=E2=80=9D as comments, whi=
le keeping pure
> descriptions of the interface as docstrings; I think it=E2=80=99s OK.  :-=
)

I fully trust your experience. ;-)


Cheers,
simon