* bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space
@ 2017-11-01 12:27 Oleg Pykhalov
2017-11-05 16:05 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2017-11-01 12:27 UTC (permalink / raw)
To: 29102
[-- Attachment #1.1: Type: text/plain, Size: 143 bytes --]
Hello Guix,
There is an issue with not enough space:
$ make check-system TESTS="btrfs-root-os"
I succeed by “double” this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Increase system disk-space for btrfs test --]
[-- Type: text/x-patch, Size: 1036 bytes --]
diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index a80c520ec..0e97de0a8 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -202,7 +202,7 @@ reboot\n")
#:imported-modules '((gnu services herd)
(guix combinators))))
(installation-disk-image-file-system-type "ext4")
- (target-size (* 1200 MiB)))
+ (target-size (* 2200 MiB)))
"Run SCRIPT (a shell script following the GuixSD installation procedure) in
OS to install TARGET-OS. Return a VM image of TARGET-SIZE bytes containing
the installed system. The packages specified in PACKAGES will be appended to
@@ -793,7 +793,7 @@ export GUIX_BUILD_OPTIONS=--no-grafts
ls -l /run/current-system/gc-roots
parted --script /dev/vdb mklabel gpt \\
mkpart primary ext2 1M 3M \\
- mkpart primary ext2 3M 1G \\
+ mkpart primary ext2 3M 2G \\
set 1 boot on \\
set 1 bios_grub on
mkfs.btrfs -L my-root /dev/vdb2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space
2017-11-01 12:27 bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space Oleg Pykhalov
@ 2017-11-05 16:05 ` Ludovic Courtès
2017-11-07 19:44 ` Oleg Pykhalov
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-11-05 16:05 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 29102
Hi Oleg,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> There is an issue with not enough space:
>
> $ make check-system TESTS="btrfs-root-os"
>
> I succeed by “double” this:
Good catch.
> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
> index a80c520ec..0e97de0a8 100644
> --- a/gnu/tests/install.scm
> +++ b/gnu/tests/install.scm
> @@ -202,7 +202,7 @@ reboot\n")
> #:imported-modules '((gnu services herd)
> (guix combinators))))
> (installation-disk-image-file-system-type "ext4")
> - (target-size (* 1200 MiB)))
> + (target-size (* 2200 MiB)))
Maybe you can even change this one to 'guess?
Otherwise OK to push to master, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space
2017-11-05 16:05 ` Ludovic Courtès
@ 2017-11-07 19:44 ` Oleg Pykhalov
2017-11-11 17:45 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2017-11-07 19:44 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 29102
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
Hello Ludovic,
Thank you for review.
ludo@gnu.org (Ludovic Courtès) writes:
> Hi Oleg,
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> There is an issue with not enough space:
>>
>> $ make check-system TESTS="btrfs-root-os"
>>
>> I succeed by “double” this:
>
> Good catch.
>
>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>> index a80c520ec..0e97de0a8 100644
>> --- a/gnu/tests/install.scm
>> +++ b/gnu/tests/install.scm
>> @@ -202,7 +202,7 @@ reboot\n")
>> #:imported-modules '((gnu services herd)
>> (guix combinators))))
>> (installation-disk-image-file-system-type "ext4")
>> - (target-size (* 1200 MiB)))
>> + (target-size (* 2200 MiB)))
>
> Maybe you can even change this one to 'guess?
No, because it will fail doing number->string on symbol here:
(system* "qemu-img" "create" "-f" "qcow2"
#$output #$(number->string target-size))
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space
2017-11-07 19:44 ` Oleg Pykhalov
@ 2017-11-11 17:45 ` Ludovic Courtès
2017-11-14 21:53 ` Oleg Pykhalov
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-11-11 17:45 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 29102
Hi,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Hi Oleg,
>>
>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>
>>> There is an issue with not enough space:
>>>
>>> $ make check-system TESTS="btrfs-root-os"
>>>
>>> I succeed by “double” this:
>>
>> Good catch.
>>
>>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>>> index a80c520ec..0e97de0a8 100644
>>> --- a/gnu/tests/install.scm
>>> +++ b/gnu/tests/install.scm
>>> @@ -202,7 +202,7 @@ reboot\n")
>>> #:imported-modules '((gnu services herd)
>>> (guix combinators))))
>>> (installation-disk-image-file-system-type "ext4")
>>> - (target-size (* 1200 MiB)))
>>> + (target-size (* 2200 MiB)))
>>
>> Maybe you can even change this one to 'guess?
>
> No, because it will fail doing number->string on symbol here:
>
> (system* "qemu-img" "create" "-f" "qcow2"
> #$output #$(number->string target-size))
Good point. In that case please push the initial patch.
Thank you,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space
2017-11-11 17:45 ` Ludovic Courtès
@ 2017-11-14 21:53 ` Oleg Pykhalov
0 siblings, 0 replies; 5+ messages in thread
From: Oleg Pykhalov @ 2017-11-14 21:53 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 29102-done, 29102
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Hello Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
[...]
>>>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>>>> index a80c520ec..0e97de0a8 100644
>>>> --- a/gnu/tests/install.scm
>>>> +++ b/gnu/tests/install.scm
>>>> @@ -202,7 +202,7 @@ reboot\n")
>>>> #:imported-modules '((gnu services herd)
>>>> (guix combinators))))
>>>> (installation-disk-image-file-system-type "ext4")
>>>> - (target-size (* 1200 MiB)))
>>>> + (target-size (* 2200 MiB)))
>>>
>>> Maybe you can even change this one to 'guess?
>>
>> No, because it will fail doing number->string on symbol here:
>>
>> (system* "qemu-img" "create" "-f" "qcow2"
>> #$output #$(number->string target-size))
>
> Good point. In that case please push the initial patch.
OK, pushed as 5724a14e71f21ccfe865ed6fadae3f7683fc66e2
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-14 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 12:27 bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not enough space Oleg Pykhalov
2017-11-05 16:05 ` Ludovic Courtès
2017-11-07 19:44 ` Oleg Pykhalov
2017-11-11 17:45 ` Ludovic Courtès
2017-11-14 21:53 ` Oleg Pykhalov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).