unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: 33310@debbugs.gnu.org
Subject: bug#33310: Cuirass: Evaluations adding no new builds are displayed as "failing"
Date: Thu, 08 Nov 2018 10:34:22 +0100	[thread overview]
Message-ID: <87y3a352w1.fsf@lassieur.org> (raw)

Hi,

Evaluations adding no new builds are displayed as "failing".  I know
this was done on purpose, but I think the check should be done on the
number of jobs returned by the evaluator, rather than on the number of
builds registered in the database.

There is a difference because derivations that are already in the
database won't be added again.

In my case (https://cuirass.lassieur.org/jobset/guix-manifest-clem), 70%
of the evaluations add no new builds, and none of them are failing.

--8<---------------cut here---------------start------------->8---
    (with-store store
      (let ((jobs (evaluate store spec eval-id checkouts)))
        (log-message "building ~a jobs for '~a'"
                     (length jobs) name)
        (build-packages store jobs eval-id)))
--8<---------------cut here---------------end--------------->8---

Thus if (zero? (length jobs)) here, we should mark the corresponding
evaluation as failing.

Thanks,
Clément

             reply	other threads:[~2018-11-08  9:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  9:34 Clément Lassieur [this message]
2018-11-11 13:37 ` bug#33310: Cuirass: Evaluations adding no new builds are displayed as "failing" Ludovic Courtès
2021-03-25 12:54   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3a352w1.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=33310@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).