From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: bug#33310: Cuirass: Evaluations adding no new builds are displayed as
	"failing"
Date: Thu, 08 Nov 2018 10:34:22 +0100
Message-ID: <87y3a352w1.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55318)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKgiP-0004eI-Gz
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:35:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKgiM-0001dY-8j
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:35:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:36049)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gKgiM-0001dC-4A
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:35:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKgiL-0003RV-Sk
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:35:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33310.B.154166969213211@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1gKghz-0004be-TR
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:34:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1gKghw-0001Bo-DE
	for bug-guix@gnu.org; Thu, 08 Nov 2018 04:34:39 -0500
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 33310@debbugs.gnu.org

Hi,

Evaluations adding no new builds are displayed as "failing".  I know
this was done on purpose, but I think the check should be done on the
number of jobs returned by the evaluator, rather than on the number of
builds registered in the database.

There is a difference because derivations that are already in the
database won't be added again.

In my case (https://cuirass.lassieur.org/jobset/guix-manifest-clem), 70%
of the evaluations add no new builds, and none of them are failing.

--8<---------------cut here---------------start------------->8---
    (with-store store
      (let ((jobs (evaluate store spec eval-id checkouts)))
        (log-message "building ~a jobs for '~a'"
                     (length jobs) name)
        (build-packages store jobs eval-id)))
--8<---------------cut here---------------end--------------->8---

Thus if (zero? (length jobs)) here, we should mark the corresponding
evaluation as failing.

Thanks,
Cl=C3=A9ment