unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Carl Dong <contact@carldong.me>
Cc: 47935@debbugs.gnu.org
Subject: bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs
Date: Thu, 03 Jun 2021 21:29:09 +0200	[thread overview]
Message-ID: <87y2bqu4qi.fsf@gnu.org> (raw)
In-Reply-To: <A93F37F7-ADA3-48FF-A1D4-800842F706AB@carldong.me> (Carl Dong's message of "Wed, 21 Apr 2021 11:35:50 -0400")

Hi Carl,

Carl Dong <contact@carldong.me> skribis:

> I’m continuing my testing of the 1.3.0 branch, and I’ve found that coreutil's tests/tail-2/inotify-dir-recreate.sh fails on filesystems where tail detects that it cannot use inotify safely (probably arising out of this check: https://github.com/coreutils/coreutils/blob/34a48bf0f0552aaed21a7dba4a5488946a978317/src/tail.c#L2486-L2491). Example for this: overlayfs used by docker/podman/etc.
>
> The author of tail’s inotify support explains it here: https://github.com/containers/podman/issues/5493#issuecomment-598851397

[...]

> Upstream bug filed: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47940

With people more on more interested in finally getting ‘core-updates’
merged, now’s a good time to look into this bug.  :-)

In the bug report upstream, you hint at a possible fix.  Could you
provide a patch for this?

Alternatively, if that turns out to be too tricky, can you think of a
workaround, such as skipping the offending code during tests?

Thanks,
Ludo’.




      parent reply	other threads:[~2021-06-03 19:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 15:35 bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs Carl Dong
2021-04-22  1:20 ` Carl Dong
2021-06-03 19:29 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2bqu4qi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=47935@debbugs.gnu.org \
    --cc=contact@carldong.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).