unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / Atom feed
* bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs
@ 2021-04-21 15:35 Carl Dong
  2021-04-22  1:20 ` Carl Dong
  2021-06-03 19:29 ` Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: Carl Dong @ 2021-04-21 15:35 UTC (permalink / raw)
  To: 47935

Hi all,

I’m continuing my testing of the 1.3.0 branch, and I’ve found that coreutil's tests/tail-2/inotify-dir-recreate.sh fails on filesystems where tail detects that it cannot use inotify safely (probably arising out of this check: https://github.com/coreutils/coreutils/blob/34a48bf0f0552aaed21a7dba4a5488946a978317/src/tail.c#L2486-L2491). Example for this: overlayfs used by docker/podman/etc.

The author of tail’s inotify support explains it here: https://github.com/containers/podman/issues/5493#issuecomment-598851397

A quick and easy fix for v1.3.0 may be to just disable tests/tail-2/inotify-dir-recreate.sh :-)

Cheers,
Carl Dong
contact@carldong.me
"I fight for the users"





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs
  2021-04-21 15:35 bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs Carl Dong
@ 2021-04-22  1:20 ` Carl Dong
  2021-06-03 19:29 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Carl Dong @ 2021-04-22  1:20 UTC (permalink / raw)
  To: 47935

Upstream bug filed: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47940




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs
  2021-04-21 15:35 bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs Carl Dong
  2021-04-22  1:20 ` Carl Dong
@ 2021-06-03 19:29 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2021-06-03 19:29 UTC (permalink / raw)
  To: Carl Dong; +Cc: 47935

Hi Carl,

Carl Dong <contact@carldong.me> skribis:

> I’m continuing my testing of the 1.3.0 branch, and I’ve found that coreutil's tests/tail-2/inotify-dir-recreate.sh fails on filesystems where tail detects that it cannot use inotify safely (probably arising out of this check: https://github.com/coreutils/coreutils/blob/34a48bf0f0552aaed21a7dba4a5488946a978317/src/tail.c#L2486-L2491). Example for this: overlayfs used by docker/podman/etc.
>
> The author of tail’s inotify support explains it here: https://github.com/containers/podman/issues/5493#issuecomment-598851397

[...]

> Upstream bug filed: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47940

With people more on more interested in finally getting ‘core-updates’
merged, now’s a good time to look into this bug.  :-)

In the bug report upstream, you hint at a possible fix.  Could you
provide a patch for this?

Alternatively, if that turns out to be too tricky, can you think of a
workaround, such as skipping the offending code during tests?

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-03 19:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 15:35 bug#47935: coreutils: tests/tail-2/inotify-dir-recreate.sh fails on overlayfs Carl Dong
2021-04-22  1:20 ` Carl Dong
2021-06-03 19:29 ` Ludovic Courtès

unofficial mirror of bug-guix@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-bugs/0 guix-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-bugs guix-bugs/ https://yhetil.org/guix-bugs \
		bug-guix@gnu.org
	public-inbox-index guix-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.bugs
	nntp://news.gmane.io/gmane.comp.gnu.guix.bugs


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git