From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: 20255@debbugs.gnu.org
Subject: bug#20255: 'search-paths' should respect both user and system profile.
Date: Sat, 21 Nov 2015 21:10:17 +0100 [thread overview]
Message-ID: <87wptb5d1y.fsf@gnu.org> (raw)
In-Reply-To: <874mgfkxee.fsf@gmail.com> (Alex Kost's message of "Sat, 21 Nov 2015 21:41:45 +0300")
Alex Kost <alezost@gmail.com> skribis:
> Ludovic Courtès (2015-11-21 11:57 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> Ludovic Courtès (2015-11-20 01:32 +0300) wrote:
>>>
>>>> -# Load the system profile's settings.
>>>> +if [ -x /run/current-system/profile/bin/guix ]
>>>> +then
>>>> + # Crucial variables such as 'MANPATH' or 'INFOPATH' may be missing from the
>>>> + # profiles' individual 'etc/profile'. Thus, combine both profiles when
>>>> + # computing the search paths.
>>>> + #
>>>> + # This may take a few hundred milliseconds, but it's OK because this is
>>>> + # performed for log-in shells only.
>>>> + eval `/run/current-system/profile/bin/guix package \\
>>>> + -p /run/current-system/profile \\
>>>> + -p \"$HOME/.guix-profile\" --search-paths`
>>>
>>> Sorry, but it's not OK for me. As a user, I'm *strongly* against
>>> running 'guix' (or any other program) in /etc/profile.
>>
>> Why? (Honest question.)
>
> At first, because of the slowdown: it may be a few hundred milliseconds
> for you, but it's several seconds for me.
Really? Can you show the output of:
time guix package -p /run/current-system/profile \
-p ~/.guix-profile --search-paths
?
> But actually, even if it was several milliseconds, I still wouldn't
> like it, as (IMHO) /etc/profile should only set variables, and not run
> external programs.
I don’t buy this “principle”: /etc/profile is a program, and the output
of --search-paths is trusted to contain only environment variable
setting.
In the discussion of this bug, we tried hard to avoid resorting to
invoking a program, but ultimately no other solution came out.
>>> I would really like to have an option to avoid this. Is it possible?
>>
>> Not that I know of. Please read <http://bugs.gnu.org/20255>.
>
> What about making some environment variable which will be honored by
> 'operating-system-etc-service' procedure. So depending on this variable
> that 'eval ...' command will or will not be added to "/etc/profile"
> during 'guix system ...' process.
>
> For example, when I do:
>
> GUIX_IGNORE_SYSTEM_PROFILE_ENV=1 guix system build my-config.scm
>
> the "etc/profile" of the built system will not contain those 'eval ...'
> lines. WDYT?
This would be unreasonable. We’re talking about a basic feature here.
If basic features are broken to the point that we prefer to offer ways
to bypass them, and have a semi-broken system, then there’s a problem,
IMO.
Ludo’.
next prev parent reply other threads:[~2015-11-21 20:11 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 10:29 bug#20255: 'search-paths' should respect both user and system profile 宋文武
2015-04-04 21:04 ` Ludovic Courtès
2015-04-05 3:39 ` 宋文武
2015-04-05 18:15 ` Ludovic Courtès
2015-04-06 4:02 ` 宋文武
2015-04-06 8:24 ` Mark H Weaver
2015-05-02 22:12 ` Ludovic Courtès
2015-11-19 22:32 ` Ludovic Courtès
2015-11-20 22:42 ` Alex Kost
2015-11-21 8:57 ` Ludovic Courtès
2015-11-21 18:41 ` Alex Kost
2015-11-21 20:10 ` Ludovic Courtès [this message]
2015-11-22 7:52 ` Alex Kost
2015-11-22 10:52 ` Ludovic Courtès
2015-11-22 18:44 ` Alex Kost
2015-11-22 23:04 ` Ludovic Courtès
2015-11-23 11:55 ` Alex Kost
2015-11-23 14:31 ` Ludovic Courtès
2015-11-24 17:22 ` Ludovic Courtès
2015-11-30 9:08 ` Alex Kost
2015-11-30 12:25 ` Ludovic Courtès
2015-05-04 21:44 ` Ludovic Courtès
2015-05-05 8:28 ` 宋文武
2015-05-05 12:35 ` Ludovic Courtès
2015-05-06 16:35 ` Ludovic Courtès
2015-11-12 11:13 ` Ludovic Courtès
2020-02-21 15:53 ` bug#20255: (old)bug#20255: 'search-paths' should respect both user and system profiles zimoun
2020-02-21 17:18 ` Alex Kost
2021-06-26 2:37 ` bug#20255: 'search-paths' should respect both user and system profile Maxim Cournoyer
2021-06-26 5:59 ` Leo Prikler
2021-06-28 4:35 ` Maxim Cournoyer
2021-06-28 6:58 ` Leo Prikler
2021-06-27 9:59 ` Alex Kost
2021-06-28 4:48 ` Maxim Cournoyer
2021-06-29 17:29 ` Alex Kost
2020-12-18 20:27 ` bug#20255: «the Oldest» [PATCH] 'search-paths' should respect both user and system profiles zimoun
2023-05-12 12:34 ` bug#20255: 'search-paths' should respect both user and system profile 宋文武 via Bug reports for GNU Guix
2023-05-15 13:53 ` Maxim Cournoyer
2023-05-15 17:14 ` Josselin Poiret via Bug reports for GNU Guix
2023-05-15 17:46 ` Maxim Cournoyer
2023-05-16 9:37 ` Josselin Poiret via Bug reports for GNU Guix
2023-05-16 11:00 ` 宋文武 via Bug reports for GNU Guix
2023-05-17 14:04 ` bug#20255: [PATCH 1/4] home: shells: Merge search-paths of multiple profiles iyzsong--- via Bug reports for GNU Guix
2023-05-17 14:04 ` bug#20255: [PATCH 2/4] system: default-skeletons: Set up Guix home profile when it exists iyzsong--- via Bug reports for GNU Guix
2023-05-17 14:04 ` bug#20255: [PATCH 3/4] system: Only source system profile's settings in '/etc/profile' iyzsong--- via Bug reports for GNU Guix
2023-05-17 14:04 ` bug#20255: [PATCH 4/4] news: Add entry for '/etc/profile' changes iyzsong--- via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wptb5d1y.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=20255@debbugs.gnu.org \
--cc=alezost@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).