unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#62365: 'guix style' sometimes makes poor indentation choices
@ 2023-03-22  2:06 Maxim Cournoyer
  0 siblings, 0 replies; only message in thread
From: Maxim Cournoyer @ 2023-03-22  2:06 UTC (permalink / raw)
  To: 62365

Hi,

Looking at #61263, there's an example of some indentation choice gone
wrong:

--8<---------------cut here---------------start------------->8---
@@ -705,59 +705,63 @@ (define-public dbacl
   (package
     (name "dbacl")
     (version "1.14.1")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "mirror://sourceforge/dbacl/dbacl/" version "/"
-                           "dbacl-" version ".tar.gz"))
-       (sha256
-        (base32 "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
-       (patches (search-patches "dbacl-include-locale.h.patch"))))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/dbacl/dbacl/"
+                                  version
+                                  "/"
+                                  "dbacl-"
+                                  version
+                                  ".tar.gz"))
+              (sha256
+               (base32
+                "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
+              (patches (search-patches "dbacl-include-locale.h.patch"
+                        "dbacl-icheck-multiple-definitions.patch"))))
     (build-system gnu-build-system)
     (arguments
--8<---------------cut here---------------end--------------->8---

The original was superior, at least for the URI part, which is now
overly broken into multiple lines, not making good use of the available
80 characters of width available.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-22  2:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22  2:06 bug#62365: 'guix style' sometimes makes poor indentation choices Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).