From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 66279@debbugs.gnu.org
Subject: bug#66279: Unexporting <user-account>
Date: Sun, 01 Oct 2023 16:28:31 -0400 [thread overview]
Message-ID: <87wmw65bps.fsf@gmail.com> (raw)
In-Reply-To: <87jzs8t1hw.fsf@inria.fr> ("Ludovic Courtès"'s message of "Sat, 30 Sep 2023 12:10:51 +0200")
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> Commit 03795e2ba27424fc98957da00f6c71325e7ae425 exports the
> <user-account> record type descriptor (RTD).
>
> Common practice is to keep RTDs private because by publishing them, we
> make it harder to change the ABI (because users might be matching fields
> positionally) and we make it trivial for users to forge records of that
> type, bypassing any checks we may have in the official constructor (such
> as “sanitizers”).
Perhaps we should document this? More power to the users!
> What do you think of reverting this commit? I don’t see references to
> <user-account> outside of its module.
I'd like to note there are also valid usages requiring a record type,
such as 'match-record' from (guix records). Otherwise, I don't feel
strongly about it, but if if's done I think the rationale you gave above
should be documented in our contributing guidelines.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-01 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 10:10 bug#66279: Unexporting <user-account> Ludovic Courtès
2023-10-01 20:28 ` Maxim Cournoyer [this message]
2023-10-05 21:28 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmw65bps.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66279@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).