From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uKaVEJjWGWW9egAAG6o9tA:P1 (envelope-from ) for ; Sun, 01 Oct 2023 22:29:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uKaVEJjWGWW9egAAG6o9tA (envelope-from ) for ; Sun, 01 Oct 2023 22:29:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12E9C496D1 for ; Sun, 1 Oct 2023 22:29:12 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=UBDws8Cy; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696192152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wCksUy/uZitxPJ/zxV19DFR0UDLRND14YMQzNJY29to=; b=rVBS5F9/x4SQLrMXnFabuBMoGLr+JjNooZxd9QHdW7VC/2Bul2vfwp9jkyKLqjr7MySVJg eol1xmmiRVHBE/q5VG6GQ2xBTTr1AIU2A3MPQ3MrcjuIQoTbkYMDGTdEmnvKjo7jRaPWf4 388llshEp80oFu3XNDXPTt2CShv1c1HvqIshH0smygll1dLznk+Dkyuu93ZpRoFDDHPsuH TpCqwxO930hu0/TuuiuZ2tJ0N2e+QM3aWVJvwOgIqaLSnkBpAmiOEvLmLixpMCXOepCMhD cqVVOtPD+fLmosHwaVkiRYmdieKBy3YZyNxslW7G71lJL+vTNguuAPcK9dq2Qg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696192152; a=rsa-sha256; cv=none; b=Txd+d1GJ55VSPLnufaldYhKj83HYuOAlg2UMXMG3DvazMR+cyn9I4YCC7IgQcctq44hYH1 axQXSEsKZsrjTJQn+ojZR9Rz0dKLADs0Y11YQb6UkME7L6FsGMLFMn/fNpsl/I1kfUQQcw YT4a26NB5LX0/ldBSsfiSVcynKHYmTZw84sNiocLCsnr3rwXJR/JZ0d2P+0fNsRBFAhEpx PKgqh90MC1yQB8ZffHTeZ5JVTzR2YAz4HPFIzg62KXoA7Yy9sN+hH+aa3Yd43ndrM96/yQ 4zk8ijZqeZMRpUQX8WpWByMWc9GzEC3Qcnqj/cdP33WT/RZDR1f+7fMzO5T/pA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=UBDws8Cy; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qn33X-0008LK-DP; Sun, 01 Oct 2023 16:28:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qn33V-0008L6-UC for bug-guix@gnu.org; Sun, 01 Oct 2023 16:28:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qn33V-0005AD-M1 for bug-guix@gnu.org; Sun, 01 Oct 2023 16:28:45 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qn33l-0007B6-Pt for bug-guix@gnu.org; Sun, 01 Oct 2023 16:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66279: Unexporting Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 01 Oct 2023 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66279 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 66279@debbugs.gnu.org Received: via spool by 66279-submit@debbugs.gnu.org id=B66279.169619213727581 (code B ref 66279); Sun, 01 Oct 2023 20:29:01 +0000 Received: (at 66279) by debbugs.gnu.org; 1 Oct 2023 20:28:57 +0000 Received: from localhost ([127.0.0.1]:35475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn33h-0007An-CZ for submit@debbugs.gnu.org; Sun, 01 Oct 2023 16:28:57 -0400 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]:49600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn33f-0007AY-II for 66279@debbugs.gnu.org; Sun, 01 Oct 2023 16:28:55 -0400 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-65af75a0209so70584096d6.3 for <66279@debbugs.gnu.org>; Sun, 01 Oct 2023 13:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696192113; x=1696796913; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wCksUy/uZitxPJ/zxV19DFR0UDLRND14YMQzNJY29to=; b=UBDws8CyOtQye4clj0TTqYBi2tM7i45r/fsXDczZzDXXpmVFSQq6Cn/cSkhfsVHRKB ZJ5BeK0Gv6EeUNYoljcuHjehoVLS77BFfdDb2TvyQq7vRjyiauDRTD7qsnqKEWgsRGxS ER8JxPCVpHXuAJyBlFRpTYyplx/RxVcFQN5y3+kog4j3uU37IiaTr86y4U20shtdlBbL aBLJjFrfpqOiXrW9aImNsjexQUKXwOMpMIU6HLFgtgpLQ0WsY03ZV3X2lOeKwK7b4cx0 GvYh8pmkYy762JKIMXebU3WBk5xrWFyzKk4mriLXllKAQf5l/LhiWw/4TvPyMeVuzUgt XsDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696192113; x=1696796913; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wCksUy/uZitxPJ/zxV19DFR0UDLRND14YMQzNJY29to=; b=pdoLi90Vs3ZNtYnypPuvSpJM6vl6SmB3Tg4AED3vyXlVctvM1oaXpku4ncpzVjW+l7 n8pjIIgPsmjiYnBfeWA01VQQOIimBy2Qg/iNBtdOTctieq0aKbhnNix+dd8xY6Wy7jVq kHMihJ9mIkDyv+9PENtx7Civdr/B0z2I/TRzHYQwvYKR+dMRcSnJSZIfzlI2bcdpyU76 xM2V5FN+eRka7sI8GjXjzmijRYKFrhGiclTc839Owz0tbSxwPtNRr2BskOJK4Ee39d4X n1iFWj3KIfVDmw+mcVMWSa+Z8ZYaqUi00YoQ4HsdzQ3Fyu5Mu80uUCE5NppmNiRVjesl uOPg== X-Gm-Message-State: AOJu0YyZh5ODyYNMC2W5jv8yNisvE08X2MkctNP9bqNitz5HO85e2+el YDMYuL5nSMRi3X5r9MQHsnpa0gifR5Q= X-Google-Smtp-Source: AGHT+IGb17n39UBve+q7jZD5dA1hPRehbdQhy4n+/R9dhfCAXpXIO15vfdLDMUmFH5LiFxnHtPexkQ== X-Received: by 2002:a05:6214:321:b0:636:afa1:345d with SMTP id j1-20020a056214032100b00636afa1345dmr8392400qvu.17.1696192113397; Sun, 01 Oct 2023 13:28:33 -0700 (PDT) Received: from hurd (dsl-10-136-90.b2b2c.ca. [72.10.136.90]) by smtp.gmail.com with ESMTPSA id n17-20020a0ce491000000b0065af657de01sm7241794qvl.115.2023.10.01.13.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 13:28:32 -0700 (PDT) From: Maxim Cournoyer References: <87jzs8t1hw.fsf@inria.fr> Date: Sun, 01 Oct 2023 16:28:31 -0400 In-Reply-To: <87jzs8t1hw.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 30 Sep 2023 12:10:51 +0200") Message-ID: <87wmw65bps.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.84 X-Migadu-Spam-Score: 2.84 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 12E9C496D1 X-TUID: u0i4EovelhCU Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Commit 03795e2ba27424fc98957da00f6c71325e7ae425 exports the > record type descriptor (RTD). > > Common practice is to keep RTDs private because by publishing them, we > make it harder to change the ABI (because users might be matching fields > positionally) and we make it trivial for users to forge records of that > type, bypassing any checks we may have in the official constructor (such > as =E2=80=9Csanitizers=E2=80=9D). Perhaps we should document this? More power to the users! > What do you think of reverting this commit? I don=E2=80=99t see referenc= es to > outside of its module. I'd like to note there are also valid usages requiring a record type, such as 'match-record' from (guix records). Otherwise, I don't feel strongly about it, but if if's done I think the rationale you gave above should be documented in our contributing guidelines. --=20 Thanks, Maxim