From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35640@debbugs.gnu.org
Subject: bug#35640: Make USB modems just work on Guix
Date: Thu, 09 May 2019 17:24:39 +0200 [thread overview]
Message-ID: <87v9yjd51k.fsf@gnu.org> (raw)
In-Reply-To: <20190508182607.wcjfxkoqwcvzrdmt@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Wed, 8 May 2019 20:26:07 +0200")
Hi Florian,
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
>From 5e9b45fe785dee52da2a67fbecbabc4741f85e54 Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Tue, 7 May 2019 11:51:43 +0200
> Subject: [PATCH 1/2] services: Include ModemManager in %desktop-services.
>
> * gnu/services/desktop.scm (%desktop-services): Add modem-manager-service-type.
> ---
> gnu/services/desktop.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 5e0bd102a2..c0300c0ddc 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -1062,6 +1062,9 @@ dispatches events from it.")))
>
> ;; The D-Bus clique.
> (service network-manager-service-type)
> + (service modem-manager-service-type) ;the manual claims this were
> + ;part of %desktop-services, but
> + ;it wasn’t
The comment is unnecessary, but otherwise LGTM!
I’ve confirmed that there is no size increase:
--8<---------------cut here---------------start------------->8---
$ guix size network-manager | tail -1
total: 534.9 MiB
$ guix size network-manager modem-manager | tail -1
total: 534.9 MiB
--8<---------------cut here---------------end--------------->8---
>From d489f805599ea63e2e06727a3201572ee0480a60 Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Wed, 8 May 2019 20:02:00 +0200
> Subject: [PATCH 2/2] gnu: network-manager-applet: Propagate packages required
> for USB modem setup.
>
> * gnu/packages/gnome.scm (network-manager-applet): Propagate iso-codes and
> mobile-broadband-provider-info.
> (gnome-control-center): Ditto.
Would it be an option to avoid propagation by instead substituting
references to these two things in the code of network-manager-applet and
gnome-control-center? WDYT?
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-05-09 15:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 18:26 bug#35640: Make USB modems just work on Guix pelzflorian (Florian Pelz)
2019-05-09 5:31 ` pelzflorian (Florian Pelz)
2019-05-09 12:55 ` Danny Milosavljevic
2019-05-09 13:07 ` pelzflorian (Florian Pelz)
2019-05-09 13:43 ` pelzflorian (Florian Pelz)
2019-05-09 15:24 ` Ludovic Courtès [this message]
2019-05-13 20:57 ` pelzflorian (Florian Pelz)
2019-05-13 21:04 ` pelzflorian (Florian Pelz)
2019-05-14 7:22 ` pelzflorian (Florian Pelz)
2019-05-14 8:35 ` Danny Milosavljevic
2019-05-14 20:56 ` pelzflorian (Florian Pelz)
2019-05-15 13:01 ` Ludovic Courtès
2019-05-15 14:40 ` pelzflorian (Florian Pelz)
2019-05-22 16:29 ` pelzflorian (Florian Pelz)
2019-05-22 17:58 ` pelzflorian (Florian Pelz)
2019-05-24 15:37 ` Ludovic Courtès
2019-05-24 20:12 ` pelzflorian (Florian Pelz)
2019-05-25 11:18 ` pelzflorian (Florian Pelz)
2019-05-25 12:43 ` pelzflorian (Florian Pelz)
2019-05-25 17:44 ` Ludovic Courtès
2019-05-25 19:42 ` pelzflorian (Florian Pelz)
2019-06-12 10:36 ` pelzflorian (Florian Pelz)
2019-06-12 10:41 ` pelzflorian (Florian Pelz)
2019-06-12 21:00 ` Ludovic Courtès
2019-06-12 21:11 ` Ludovic Courtès
2019-06-13 18:04 ` pelzflorian (Florian Pelz)
2019-06-13 18:05 ` pelzflorian (Florian Pelz)
2019-06-15 16:39 ` Ludovic Courtès
2019-06-12 12:13 ` pelzflorian (Florian Pelz)
2019-06-12 12:21 ` Ludovic Courtès
2019-06-12 19:51 ` pelzflorian (Florian Pelz)
2019-06-12 20:42 ` Ludovic Courtès
2019-06-12 20:58 ` Ludovic Courtès
2019-05-14 20:48 ` Ludovic Courtès
2019-05-15 11:17 ` pelzflorian (Florian Pelz)
2019-05-15 12:51 ` Ludovic Courtès
2019-05-16 7:50 ` pelzflorian (Florian Pelz)
2019-05-16 8:34 ` pelzflorian (Florian Pelz)
2019-05-16 11:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9yjd51k.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35640@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).