From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35640@debbugs.gnu.org
Subject: bug#35640: Make USB modems just work on Guix
Date: Sat, 25 May 2019 19:44:37 +0200 [thread overview]
Message-ID: <87lfyupgxm.fsf@gnu.org> (raw)
In-Reply-To: <20190525111856.jfu5ly2p6ynn3rdk@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sat, 25 May 2019 13:18:56 +0200")
Hello,
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> Please find attached a patch that no longer propagates
> usb-modeswitch-data from usb-modeswitch. I can now modeswitch my USB
> modem by running
Yay!
> The udev rules file in usb-modeswitch-data has lines like:
>
> ATTR{idVendor}=="03f0", ATTR{idProduct}=="002a", RUN+="usb_modeswitch '/%k'"
>
> Maybe I should substitute these by
>
> RUN+="/gnu/store/…-usb-modeswich-2.5.2/usb_modeswitch '/%k'"
>
> but this would introduce a cyclic dependency between usb-modeswitch
> and usb-modeswitch-data. Therefore this rules file should rather be
> fixed in a future USB_ModeSwitch service type.
Sounds good. Another option would be to install the udev rule as part
of the ‘usb-modeswitch’ package, which makes more sense and would solve
the problem. But anyway, don’t lose your hair over it.
>> + (substitute* "usb_modeswitch_dispatcher"
>> + (("!/usr/bin/tclsh")
>> + (string-append "!" jimtcl "/bin/jimsh"))
I don’t think it’s needed, is it?
>> + (("/usr/sbin") bin)
>> + (("/usr/share/usb_modeswitch")
>> + (string-append data "/share/usb_modeswitch.d"))
>> + (("\\[ParseGlobalConfig\\]") ;use config in command line
>> + "[ParseGlobalConfig $argv]")
>> + (("proc \\{ParseGlobalConfig\\} \\{\\}")
>> + "proc {ParseGlobalConfig} {argv}")
>> + (("set configFile \\\"\\\"")
>> + "
>> +if {[lindex $argv 2] == \"--config-file\"} {
>> + set configFile [lindex $argv 3]
>> +}"))
>
>
> Or should I rather use a patch file instead of substitute*?
I think it’s OK like this. It does mean Guix’s
‘usb_modeswitch_dispatcher’ has an option that upstream doesn’t provide.
It would be worth proposing it upstream.
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-05-25 17:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 18:26 bug#35640: Make USB modems just work on Guix pelzflorian (Florian Pelz)
2019-05-09 5:31 ` pelzflorian (Florian Pelz)
2019-05-09 12:55 ` Danny Milosavljevic
2019-05-09 13:07 ` pelzflorian (Florian Pelz)
2019-05-09 13:43 ` pelzflorian (Florian Pelz)
2019-05-09 15:24 ` Ludovic Courtès
2019-05-13 20:57 ` pelzflorian (Florian Pelz)
2019-05-13 21:04 ` pelzflorian (Florian Pelz)
2019-05-14 7:22 ` pelzflorian (Florian Pelz)
2019-05-14 8:35 ` Danny Milosavljevic
2019-05-14 20:56 ` pelzflorian (Florian Pelz)
2019-05-15 13:01 ` Ludovic Courtès
2019-05-15 14:40 ` pelzflorian (Florian Pelz)
2019-05-22 16:29 ` pelzflorian (Florian Pelz)
2019-05-22 17:58 ` pelzflorian (Florian Pelz)
2019-05-24 15:37 ` Ludovic Courtès
2019-05-24 20:12 ` pelzflorian (Florian Pelz)
2019-05-25 11:18 ` pelzflorian (Florian Pelz)
2019-05-25 12:43 ` pelzflorian (Florian Pelz)
2019-05-25 17:44 ` Ludovic Courtès [this message]
2019-05-25 19:42 ` pelzflorian (Florian Pelz)
2019-06-12 10:36 ` pelzflorian (Florian Pelz)
2019-06-12 10:41 ` pelzflorian (Florian Pelz)
2019-06-12 21:00 ` Ludovic Courtès
2019-06-12 21:11 ` Ludovic Courtès
2019-06-13 18:04 ` pelzflorian (Florian Pelz)
2019-06-13 18:05 ` pelzflorian (Florian Pelz)
2019-06-15 16:39 ` Ludovic Courtès
2019-06-12 12:13 ` pelzflorian (Florian Pelz)
2019-06-12 12:21 ` Ludovic Courtès
2019-06-12 19:51 ` pelzflorian (Florian Pelz)
2019-06-12 20:42 ` Ludovic Courtès
2019-06-12 20:58 ` Ludovic Courtès
2019-05-14 20:48 ` Ludovic Courtès
2019-05-15 11:17 ` pelzflorian (Florian Pelz)
2019-05-15 12:51 ` Ludovic Courtès
2019-05-16 7:50 ` pelzflorian (Florian Pelz)
2019-05-16 8:34 ` pelzflorian (Florian Pelz)
2019-05-16 11:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfyupgxm.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35640@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).