unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store.
       [not found]     ` <87woerajr8.fsf@gnu.org>
@ 2019-09-03 14:39       ` Hartmut Goebel
  2019-09-04 10:32         ` Ludovic Courtès
  2019-09-26 15:53         ` Hartmut Goebel
  0 siblings, 2 replies; 5+ messages in thread
From: Hartmut Goebel @ 2019-09-03 14:39 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26175

Hi Ludo,

while http://issues.guix.gnu.org/issue/36976 is going to solve the issue
for "guix download", I found that there are other cases where invalid
characters in store names appear. Thus we need a more elaborate solution
- or several solutions.

Any suggestions which cases to check and how to fix them?


E.g. "@" and "%" are not allowed in package source base names: When
building the package below, which used the "offending URL, yields an error:

guix build: error: invalid character `@' in name
`kde-l10n-ca@valencia-14.11.80.tar.xz.drv'

Same when trying to work around this be using "…%40…".

(use-modules (guix packages) (guix download) (guix build-system gnu))

(package
  (name "kde-l10n-ca-valencia")
  (version "14.11.80")
  (source
   (origin
     (method url-fetch)
     (uri (string-append "mirror://kde//Attic/applications/"
                         version "/src/kde-l10n/"
                         "kde-l10n-ca@valencia-" version ".tar.xz"))
     (sha256 (base32
"1mqadassxcm0m9r1l02m5vr4bbandn48xz8gifvxmb4wiz8i8d0w"))))
  (build-system gnu-build-system)
  (synopsis "") (description "") (license "") (home-page ""))

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |


^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store.
  2019-09-03 14:39       ` bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store Hartmut Goebel
@ 2019-09-04 10:32         ` Ludovic Courtès
  2019-09-08 18:50           ` Hartmut Goebel
  2019-09-26 15:53         ` Hartmut Goebel
  1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-09-04 10:32 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 26175

Hi,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

>    (origin
>      (method url-fetch)
>      (uri (string-append "mirror://kde//Attic/applications/"
>                          version "/src/kde-l10n/"
>                          "kde-l10n-ca@valencia-" version ".tar.xz"))

In this case just add a ‘file-name’ field.  I think that’s a reasonable
expectation.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store.
  2019-09-04 10:32         ` Ludovic Courtès
@ 2019-09-08 18:50           ` Hartmut Goebel
  2019-09-08 20:07             ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Hartmut Goebel @ 2019-09-08 18:50 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26175

Am 04.09.19 um 12:32 schrieb Ludovic Courtès:
> Hi,
>
> Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
>
>>    (origin
>>      (method url-fetch)
>>      (uri (string-append "mirror://kde//Attic/applications/"
>>                          version "/src/kde-l10n/"
>>                          "kde-l10n-ca@valencia-" version ".tar.xz"))
> In this case just add a ‘file-name’ field.  I think that’s a reasonable
> expectation.
>
> Thanks,
> Ludo’.

Agreed. WDYT about adding this as a hint when the error shows up?

How can I catch the "error: invalid character `@' in name" in guix build?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store.
  2019-09-08 18:50           ` Hartmut Goebel
@ 2019-09-08 20:07             ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2019-09-08 20:07 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: 26175

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 04.09.19 um 12:32 schrieb Ludovic Courtès:
>> Hi,
>>
>> Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
>>
>>>    (origin
>>>      (method url-fetch)
>>>      (uri (string-append "mirror://kde//Attic/applications/"
>>>                          version "/src/kde-l10n/"
>>>                          "kde-l10n-ca@valencia-" version ".tar.xz"))
>> In this case just add a ‘file-name’ field.  I think that’s a reasonable
>> expectation.
>>
>> Thanks,
>> Ludo’.
>
> Agreed. WDYT about adding this as a hint when the error shows up?
>
> How can I catch the "error: invalid character `@' in name" in guix build?

Unfortunately it cannot really be caught.  I mean, you could catch
‘&store-protocol-error’ error conditions, but then the error message is
just a string, there’s no error code you can compare against.

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store.
  2019-09-03 14:39       ` bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store Hartmut Goebel
  2019-09-04 10:32         ` Ludovic Courtès
@ 2019-09-26 15:53         ` Hartmut Goebel
  1 sibling, 0 replies; 5+ messages in thread
From: Hartmut Goebel @ 2019-09-26 15:53 UTC (permalink / raw)
  To: 26175-close

Done, see dec845606d2d184da31065fa26cd951b84b3ce2d and
<http://issues.guix.gnu.org/issue/36976#5>

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-26 15:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190808144448.25147-1-h.goebel@crazy-compilers.com>
     [not found] ` <874l271tf6.fsf@gnu.org>
     [not found]   ` <c5b96442-0ab8-2472-b387-03ceefd7c588@crazy-compilers.com>
     [not found]     ` <87woerajr8.fsf@gnu.org>
2019-09-03 14:39       ` bug#26175: [bug#36976] [PATCH 1/1] download: Map file-name characters not allowed in store Hartmut Goebel
2019-09-04 10:32         ` Ludovic Courtès
2019-09-08 18:50           ` Hartmut Goebel
2019-09-08 20:07             ` Ludovic Courtès
2019-09-26 15:53         ` Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).