* bug#48521: opendht-service-type hangs Shepherd at boot
@ 2021-05-19 11:59 Maxim Cournoyer
2021-05-19 21:36 ` Maxim Cournoyer
2021-05-20 2:52 ` Maxim Cournoyer
0 siblings, 2 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2021-05-19 11:59 UTC (permalink / raw)
To: 48521
Hello,
I just noticed about this problem following a reboot. I can also
reproduce it in 'guix system vm', simply adding the opendht-service-type
to my operating-system declaration.
The boot proceeds until 'error in finalization thread: Success' then
hangs indefinitely.
What is troubling for me is that the service is rather straightforwardly
defined. It uses the make-forkexec-constructor/container like so:
--8<---------------cut here---------------start------------->8---
(define (opendht-shepherd-service config)
"Return a <shepherd-service> running OpenDHT."
(shepherd-service
(documentation "Run an OpenDHT node.")
(provision '(opendht dhtnode dhtproxy))
(requirement '(user-processes syslogd))
(start #~(make-forkexec-constructor/container
(list #$@(opendht-configuration->command-line-arguments config))
#:mappings (list (file-system-mapping
(source "/dev/log") ;for syslog
(target source)))
#:user "opendht"))
(stop #~(make-kill-destructor))))
--8<---------------cut here---------------end--------------->8---
I'm not sure how using such basic building blocks could lead to a hang
in Shepherd ?
Thanks,
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#48521: opendht-service-type hangs Shepherd at boot
2021-05-19 11:59 bug#48521: opendht-service-type hangs Shepherd at boot Maxim Cournoyer
@ 2021-05-19 21:36 ` Maxim Cournoyer
2021-05-20 2:52 ` Maxim Cournoyer
1 sibling, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2021-05-19 21:36 UTC (permalink / raw)
To: 48521
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello,
>
> I just noticed about this problem following a reboot. I can also
> reproduce it in 'guix system vm', simply adding the opendht-service-type
> to my operating-system declaration.
>
> The boot proceeds until 'error in finalization thread: Success' then
> hangs indefinitely.
>
> What is troubling for me is that the service is rather straightforwardly
> defined. It uses the make-forkexec-constructor/container like so:
>
> (define (opendht-shepherd-service config)
> "Return a <shepherd-service> running OpenDHT."
> (shepherd-service
> (documentation "Run an OpenDHT node.")
> (provision '(opendht dhtnode dhtproxy))
> (requirement '(user-processes syslogd))
> (start #~(make-forkexec-constructor/container
> (list #$@(opendht-configuration->command-line-arguments config))
> #:mappings (list (file-system-mapping
> (source "/dev/log") ;for syslog
> (target source)))
> #:user "opendht"))
> (stop #~(make-kill-destructor))))
>
> I'm not sure how using such basic building blocks could lead to a hang
> in Shepherd ?
After much trial and error, the service can be made to not hang Shepherd
with the removal of the mappings argument:
--8<---------------cut here---------------start------------->8---
modified gnu/services/networking.scm
@@ -845,9 +845,9 @@ CONFIG, an <opendht-configuration> object."
(requirement '(user-processes networking syslogd))
(start #~(make-forkexec-constructor/container
(list #$@(opendht-configuration->command-line-arguments config))
- #:mappings (list (file-system-mapping
- (source "/dev/log") ;for syslog
- (target source)))
+ ;; #:mappings (list (file-system-mapping
+ ;; (source "/dev/log") ;for syslog
+ ;; (target source)))
#:user "opendht"))
(stop #~(make-kill-destructor))))
--8<---------------cut here---------------end--------------->8---
I have no idea why that is, but given that the tor-service-type does the
same thing, I can only conclude that it is some strange interaction
between dhtnode and syslog.
The above fixes the hang, but breaks logging to syslog.
Ideas?
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#48521: opendht-service-type hangs Shepherd at boot
2021-05-19 11:59 bug#48521: opendht-service-type hangs Shepherd at boot Maxim Cournoyer
2021-05-19 21:36 ` Maxim Cournoyer
@ 2021-05-20 2:52 ` Maxim Cournoyer
1 sibling, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2021-05-20 2:52 UTC (permalink / raw)
To: 48521-done
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello,
>
> I just noticed about this problem following a reboot. I can also
> reproduce it in 'guix system vm', simply adding the opendht-service-type
> to my operating-system declaration.
>
> The boot proceeds until 'error in finalization thread: Success' then
> hangs indefinitely.
>
> What is troubling for me is that the service is rather straightforwardly
> defined. It uses the make-forkexec-constructor/container like so:
>
> (define (opendht-shepherd-service config)
> "Return a <shepherd-service> running OpenDHT."
> (shepherd-service
> (documentation "Run an OpenDHT node.")
> (provision '(opendht dhtnode dhtproxy))
> (requirement '(user-processes syslogd))
> (start #~(make-forkexec-constructor/container
> (list #$@(opendht-configuration->command-line-arguments config))
> #:mappings (list (file-system-mapping
> (source "/dev/log") ;for syslog
> (target source)))
> #:user "opendht"))
> (stop #~(make-kill-destructor))))
>
> I'm not sure how using such basic building blocks could lead to a hang
> in Shepherd ?
It seems Shepherd can't cope with a failing start procedure/script when
a variable was not bound. To diagnose the problem, the best way ended
up being to extract the code of the constructor in a separate script to
run it separately. This made the error quickly apparent: "Unbound
variable: file-system-mapping".
We should try to handle this class of errors in Shepherd and report a
useful message and *not* crash Shepherd or otherwise hang.
Pushed with commit a09cdf1f9d.
Closing.
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-20 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 11:59 bug#48521: opendht-service-type hangs Shepherd at boot Maxim Cournoyer
2021-05-19 21:36 ` Maxim Cournoyer
2021-05-20 2:52 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).