unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 59784@debbugs.gnu.org
Subject: bug#59784: [version 1.4.0rc1] Retrying a failed install fails
Date: Thu, 15 Dec 2022 21:44:37 +0100	[thread overview]
Message-ID: <87v8mcz9ai.fsf@pelzflorian.de> (raw)
In-Reply-To: <871qp05zmf.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Thu, 15 Dec 2022 18:46:16 +0100")

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Desperately I tried also adding fsync, to no avail, both issues remain.
Non-working patch attached.

Maybe dynamic-wind is an inappropriate pattern here?

If I interrupt installation using Ctrl-C (which I normally don’t,
instead I unplug Ethernet), then I have to press Ctrl-C twice.  Maybe
that could be related to why I need to resume twice?

I’m in the dark.

Regards,
Florian


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fsync-to-no-avail.patch --]
[-- Type: text/x-patch, Size: 1293 bytes --]

does not help

diff --git a/gnu/installer/final.scm b/gnu/installer/final.scm
index 5f720f6641..f5935a29c9 100644
--- a/gnu/installer/final.scm
+++ b/gnu/installer/final.scm
@@ -201,6 +201,12 @@ (define (assert-exit x)
              (stop-service 'guix-daemon)
              (copy-file database-file saved-database)
 
+             ;; Sync it to the filesystem.
+             (let* ((flags O_RDONLY)
+                    (fd (open saved-database flags)))
+               (fsync fd)
+               (close fd))
+
              (mount-cow-store (%installer-target-dir) backing-directory))
            (lambda ()
              ;; We need to drag the guix-daemon to the container MNT
@@ -218,8 +224,16 @@ (define (assert-exit x)
              ;; alive.
              (stop-service 'guix-daemon)
 
-             ;; Restore the database and restart it.
+             ;; Restore the database.
              (copy-file saved-database database-file)
+
+             ;; Sync it to the filesystem.
+             (let* ((flags O_RDONLY)
+                    (fd (open database-file flags)))
+               (fsync fd)
+               (close fd))
+
+             ;; And restart guix-daemon.
              (start-service 'guix-daemon)
 
              ;; Finally umount the cow-store and exit the container.

  reply	other threads:[~2022-12-15 20:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 17:52 bug#59784: [version 1.4.0rc1] Retrying a failed install fails pelzflorian (Florian Pelz)
2022-12-09  9:42 ` Ludovic Courtès
2022-12-09 11:11   ` Ludovic Courtès
2022-12-10  8:39   ` pelzflorian (Florian Pelz)
2022-12-13  9:40     ` Ludovic Courtès
2022-12-13  9:48       ` Ludovic Courtès
2022-12-13 22:22         ` pelzflorian (Florian Pelz)
2022-12-13 23:16           ` Ludovic Courtès
2022-12-14 13:36             ` pelzflorian (Florian Pelz)
2022-12-14 21:47               ` pelzflorian (Florian Pelz)
2022-12-14 23:50                 ` Ludovic Courtès
2022-12-15 17:46                   ` pelzflorian (Florian Pelz)
2022-12-15 20:44                     ` pelzflorian (Florian Pelz) [this message]
2022-12-16 16:57                       ` Ludovic Courtès
2022-12-16 20:28                         ` pelzflorian (Florian Pelz)
2022-12-17 11:01                           ` Ludovic Courtès
2022-12-17 19:36                             ` pelzflorian (Florian Pelz)
2022-12-17 16:15                         ` Ludovic Courtès
2022-12-17 19:27                           ` pelzflorian (Florian Pelz)
2022-12-17 21:30                             ` Ludovic Courtès
2022-12-18  0:23                               ` Ludovic Courtès
2022-12-16 13:55                 ` Maxime Devos
2022-12-16 20:17                   ` pelzflorian (Florian Pelz)
2022-12-18 16:41                 ` pelzflorian (Florian Pelz)
2022-12-12 12:07 ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8mcz9ai.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=59784@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).