From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 59784@debbugs.gnu.org
Subject: bug#59784: [version 1.4.0rc1] Retrying a failed install fails
Date: Wed, 14 Dec 2022 00:16:29 +0100 [thread overview]
Message-ID: <87h6xyvqr6.fsf@gnu.org> (raw)
In-Reply-To: <87ilifeyg1.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Tue, 13 Dec 2022 23:22:22 +0100")
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>> So my guess is that things will be much better if we swap these two
>> lines.
>
> This was helpful, but not enough.
Sorry, I think I wasn’t thinking at full speed. There needs to be zero
daemons running while we copy the database. So the real fix is more
like this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 864 bytes --]
diff --git a/gnu/installer/final.scm b/gnu/installer/final.scm
index 044f79372b..9a6bbad122 100644
--- a/gnu/installer/final.scm
+++ b/gnu/installer/final.scm
@@ -213,10 +213,13 @@ (define (assert-exit x)
(set! ret (run-command install-command #:tty? #t)))
(lambda ()
- ;; Restart guix-daemon so that it does no keep the MNT namespace
+ ;; Stop guix-daemon so that it does no keep the MNT namespace
;; alive.
- (restart-service 'guix-daemon)
+ (stop-service 'guix-daemon)
+
+ ;; Restore the database and restart it.
(copy-file saved-database database-file)
+ (start-service 'guix-daemon)
;; Finally umount the cow-store and exit the container.
(unmount-cow-store (%installer-target-dir) backing-directory)
[-- Attachment #3: Type: text/plain, Size: 910 bytes --]
>> ./pre-inst-env guix system image -t iso9660 --label=Guix \
>> gnu/system/install.scm
>
> Additionally, I had to do “GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT=y
> make update-guix-package”. Or else the installer was using a Guix that
> did not have the lines swapped.
Hmm this is surprising because we’re already using (current-guix) in
(gnu installer).
> Also before I did the GPG authorization dance (my x86 machine isn’t
> worth getting my actual commiter GPG keys, so I make sure its dummy GPG
> key is in the keyring branch, .guix-authorizations file, that
> guix/channels.scm’s default guix channel points to the url
> /home/florian/src/guix and to the commit with the new authorization).
> Then I guix pulled. So that building the installer succeeds. I did
> *not* use ./pre-inst-env.
Ah yes, apologies. You should be able to disable authentication with
this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: Type: text/x-patch, Size: 535 bytes --]
diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 5a09b1fcf8..374b187d8c 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -625,6 +625,7 @@ (define-public current-guix-package
(inherit guix)
(source source)
(build-system channel-build-system)
+ (arguments '(#:authenticate? #f))
(inputs '())
(native-inputs '())
(propagated-inputs '())))
[-- Attachment #5: Type: text/plain, Size: 73 bytes --]
Thanks a lot for patiently testing, this is very helpful!
Ludo’.
next prev parent reply other threads:[~2022-12-13 23:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 17:52 bug#59784: [version 1.4.0rc1] Retrying a failed install fails pelzflorian (Florian Pelz)
2022-12-09 9:42 ` Ludovic Courtès
2022-12-09 11:11 ` Ludovic Courtès
2022-12-10 8:39 ` pelzflorian (Florian Pelz)
2022-12-13 9:40 ` Ludovic Courtès
2022-12-13 9:48 ` Ludovic Courtès
2022-12-13 22:22 ` pelzflorian (Florian Pelz)
2022-12-13 23:16 ` Ludovic Courtès [this message]
2022-12-14 13:36 ` pelzflorian (Florian Pelz)
2022-12-14 21:47 ` pelzflorian (Florian Pelz)
2022-12-14 23:50 ` Ludovic Courtès
2022-12-15 17:46 ` pelzflorian (Florian Pelz)
2022-12-15 20:44 ` pelzflorian (Florian Pelz)
2022-12-16 16:57 ` Ludovic Courtès
2022-12-16 20:28 ` pelzflorian (Florian Pelz)
2022-12-17 11:01 ` Ludovic Courtès
2022-12-17 19:36 ` pelzflorian (Florian Pelz)
2022-12-17 16:15 ` Ludovic Courtès
2022-12-17 19:27 ` pelzflorian (Florian Pelz)
2022-12-17 21:30 ` Ludovic Courtès
2022-12-18 0:23 ` Ludovic Courtès
2022-12-16 13:55 ` Maxime Devos
2022-12-16 20:17 ` pelzflorian (Florian Pelz)
2022-12-18 16:41 ` pelzflorian (Florian Pelz)
2022-12-12 12:07 ` pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6xyvqr6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=59784@debbugs.gnu.org \
--cc=othacehe@gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).