unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 25177@debbugs.gnu.org
Subject: bug#25177: python-tests: python-oslosphinx fixed. Please evaluate.
Date: Fri, 24 Feb 2017 23:36:58 +0100	[thread overview]
Message-ID: <87tw7jfc6t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87y3wvxlwu.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>
>>>> Leo Famulari <leo@famulari.name> writes:
>>>>
>>>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>>>> From: Ricardo Wurmus <rekado@elephly.net>
>>>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>>>
>>>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>>>> tests.
>>>>>
>>>>> LGTM
>>>>
>>>> The problem was fixed in the upstream commit 93f984b in response to my
>>>> bug report:
>>>>
>>>>     https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>>>
>>>> I believe we can just backport this fix instead of deleting the test.
>>>
>>> Here’s a patch that fixes the tests by applying the changes of the
>>> upstream commit.  If this is fine I’ll push it to the python-tests
>>> branch.
>>
>> I tried this patch, and guess the reason it was not pushed is because
>> dendropy now has a different failure. Can you look into it?
>
> Oh?  I didn’t get an error building it on the “python-tests” branch on
> x86_64.  Could you show me the error messages you get?
>
> (I didn’t build python2-dendropy.)

Strange. Here python2-dendropy builds fine, but python-dendropy fails:

======================================================================
FAIL: test_collection_comments_and_annotations (dendropy.test.test_dataio_nexml_reader_tree_list.NexmlStandardTreeParsingTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-dendropy-4.2.0.drv-0/DendroPy-4.2.0/dendropy/test/test_dataio_nexml_reader_tree_list.py", line 60, in test_collection_comments_and_annotations
    expected_metadata)
  File "/tmp/guix-build-python-dendropy-4.2.0.drv-0/DendroPy-4.2.0/dendropy/test/support/standard_file_test_trees.py", line 127, in compare_annotations_to_json_metadata_dict
    self.assertEqual(item_annotations_as_dict, expected_metadata)
AssertionError: {'$_demivotary_#_monumentlike': 31, 'mangan[226 chars]alse} != {'Merycoidodon_%_$_permeant': 'envyingly247[236 chars]'31'}
Diff is 711 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 840 tests in 263.965s

FAILED (failures=1)
phase `check' failed after 266.1 seconds
builder for `/gnu/store/af6rm6s8g3cid461pvhl1j0fsyp06ifq-python-dendropy-4.2.0.drv' failed with exit code 1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-02-24 22:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170218181854.49ea3b17@scratchpost.org>
2017-02-19 23:00 ` bug#25177: python-tests: python-oslosphinx fixed. Please evaluate Marius Bakke
     [not found] ` <87bmtxkcqi.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
2017-02-21  4:16   ` Leo Famulari
     [not found]   ` <20170221041645.GC19762@jasmine>
2017-02-21  7:50     ` Ricardo Wurmus
     [not found]     ` <87h93oyod0.fsf@elephly.net>
2017-02-21 17:30       ` Ricardo Wurmus
     [not found]       ` <87zihfxxi3.fsf@elephly.net>
2017-02-21 17:47         ` Leo Famulari
2017-02-21 22:15           ` Ricardo Wurmus
2017-02-21 22:21           ` Ben Woodcroft
     [not found]           ` <87wpcjxka7.fsf@elephly.net>
2017-02-22 12:42             ` Ricardo Wurmus
2017-02-22 12:57               ` Marius Bakke
2017-02-24 22:20               ` Marius Bakke
2017-02-24 22:29                 ` Ricardo Wurmus
2017-02-24 22:36                   ` Marius Bakke [this message]
2017-02-27 11:46                 ` Marius Bakke
2017-02-27 20:20                   ` Leo Famulari
2017-02-28 16:15                     ` Marius Bakke
2017-03-01 15:36                       ` Leo Famulari
2017-03-01 17:36                         ` Marius Bakke
2017-03-01 17:44                           ` Marius Bakke
2017-03-02 22:22                             ` Leo Famulari
2017-03-02 23:31                               ` Marius Bakke
2017-03-02 23:42                                 ` Leo Famulari
2017-03-03 16:52                                   ` Marius Bakke
2017-03-03 17:51                                     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw7jfc6t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=25177@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).