* bug#70121: Magit autoloads missing in Emacs 29.3
@ 2024-04-01 3:33 Jake
2024-04-01 15:50 ` bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads Liliana Marie Prikler
0 siblings, 1 reply; 4+ messages in thread
From: Jake @ 2024-04-01 3:33 UTC (permalink / raw)
To: 70121; +Cc: liliana.prikler
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Hello
Since upgrading from Emacs 29.1 to 29.3, it seems like magit's autoload
definitions are not loaded.
To reproduce:
guix shell --pure emacs emacs-magit -- emacs -q --eval "(call-interactively
'magit)"
In Emacs 29.3 this gives me: Wrong type argument: commandp, magit
Thanks
Jake
[-- Attachment #2: Type: text/html, Size: 580 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
2024-04-01 3:33 bug#70121: Magit autoloads missing in Emacs 29.3 Jake
@ 2024-04-01 15:50 ` Liliana Marie Prikler
2024-04-03 10:27 ` Clément Lassieur
0 siblings, 1 reply; 4+ messages in thread
From: Liliana Marie Prikler @ 2024-04-01 15:50 UTC (permalink / raw)
To: 70121; +Cc: Jake
* gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
like the others.
Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
---
gnu/packages/emacs-xyz.scm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 975b26813a..f47f5fcb8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1668,6 +1668,10 @@ (define-public emacs-magit
(lambda args
(with-directory-excursion "lisp"
(apply (assoc-ref %standard-phases 'expand-load-path) args))))
+ (replace 'make-autoloads
+ (lambda args
+ (with-directory-excursion "lisp"
+ (apply (assoc-ref %standard-phases 'make-autoloads) args))))
(replace 'install
(lambda args
(with-directory-excursion "lisp"
base-commit: 4d79a9cd6b5f0d8c5afbab0c6b70ae42740d5470
prerequisite-patch-id: c275e4e44896c8ab96e5cc9557ec5dc522d62fd0
prerequisite-patch-id: 1675bb658c90730025a744f7869a3566fb5cf41a
prerequisite-patch-id: 9c02fe03b70a5312cc982fd4b48e73e889a9afdf
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
2024-04-01 15:50 ` bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads Liliana Marie Prikler
@ 2024-04-03 10:27 ` Clément Lassieur
2024-04-03 10:40 ` Clément Lassieur
0 siblings, 1 reply; 4+ messages in thread
From: Clément Lassieur @ 2024-04-03 10:27 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: Jake, 70121
On Mon, Apr 01 2024, Liliana Marie Prikler wrote:
> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
> like the others.
>
> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
> ---
Hi,
Tested, looks good to me.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads.
2024-04-03 10:27 ` Clément Lassieur
@ 2024-04-03 10:40 ` Clément Lassieur
0 siblings, 0 replies; 4+ messages in thread
From: Clément Lassieur @ 2024-04-03 10:40 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: Jake, 70121-done
On Wed, Apr 03 2024, Clément Lassieur wrote:
> On Mon, Apr 01 2024, Liliana Marie Prikler wrote:
>
>> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
>> like the others.
>>
>> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
>> ---
>
> Hi,
>
> Tested, looks good to me.
Pushed, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-03 10:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-01 3:33 bug#70121: Magit autoloads missing in Emacs 29.3 Jake
2024-04-01 15:50 ` bug#70121: [PATCH] gnu: emacs-magit: Fix generation of autoloads Liliana Marie Prikler
2024-04-03 10:27 ` Clément Lassieur
2024-04-03 10:40 ` Clément Lassieur
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).