From: "Ludovic Courtès" <ludo@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 36544@debbugs.gnu.org
Subject: bug#36544: 'set-paths' should exclude 'source' from consideration
Date: Thu, 11 Jul 2019 23:24:55 +0200 [thread overview]
Message-ID: <87sgrcnu1k.fsf@inria.fr> (raw)
In-Reply-To: <871rz1a0kr.fsf@netris.org>
Hello,
Mark H Weaver <mhw@netris.org> skribis:
> The 'set-paths' phase in (guix build gnu-build-system) currently
> includes 'source' in the set of candidates for inclusion in the
> search-path variables.
Oh, that was certainly not intended.
> First of all, I think it's undesirable to include subdirectories of the
> source directory in these search paths. However, if you think it's
> desirable, there's another problem: it's fragile. It depends on:
>
> (1) whether the source is a tarball or an unpacked checkout, and
> (2) whether the subdirectories specified in the search-paths
> (e.g. 'include') are within the top source directory.
>
> Currently, if you change the 'source' field of a package from a tarball
> to an (unpacked) VCS checkout, there *might* be additional components
> added to the environment variables, depending on the source tree layout.
>
> For example, this causes our 'linux-libre' package to fail to build if
> you substitute its 'source' field for a git checkout, as Chris Webber
> discovered here:
>
> https://lists.gnu.org/archive/html/help-guix/2019-07/msg00058.html
> https://lists.gnu.org/archive/html/help-guix/2019-07/msg00062.html
>
> Also, if any package depends on the current behavior, it will break if
> its 'source' is changed from a VCS checkout to a release tarball.
Indeed, that’s terrible. I suppose we were just lucky not to hit such
issues before!
> To avoid this unexpected sensitivity on the source origin method, I
> suggest that we explicitly exclude 'source' from consideration within
> the 'set-paths' phase. What do you think?
I agree. We should do that in the next ‘core-updates’.
Ludo’.
next prev parent reply other threads:[~2019-07-11 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 23:26 bug#36544: 'set-paths' should exclude 'source' from consideration Mark H Weaver
2019-07-11 21:24 ` Ludovic Courtès [this message]
2020-12-13 19:30 ` Leo Famulari
2020-12-13 19:35 ` Marius Bakke
2020-06-01 4:51 ` Aiko Kyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgrcnu1k.fsf@inria.fr \
--to=ludo@gnu.org \
--cc=36544@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).