* bug#43533: guix-daemon fails to start in Childhurd
@ 2020-09-20 15:05 Jan Nieuwenhuizen
2020-09-21 8:30 ` Mathieu Othacehe
0 siblings, 1 reply; 3+ messages in thread
From: Jan Nieuwenhuizen @ 2020-09-20 15:05 UTC (permalink / raw)
To: 43533; +Cc: Mathieu Othacehe
Hi!
On current master (6feb7a2107000f9ded547543dcda9d64402c6081), the
shepherd in a Childhurd fails to start the guix-daemon. It does start
when invoked manually, using the same arguments *)
The culprit seems to be the usage of fork+exec-command/container:
After applying this patch
--8<---------------cut here---------------start------------->8---
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index d560ad5a13..98a8d2abca 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1570,7 +1570,7 @@ proxy of 'guix-daemon'...~%")
;; the 'set-http-proxy' action.
(or (getenv "http_proxy") #$http-proxy))
- (fork+exec-command/container
+ (fork+exec-command
(cons* #$(file-append guix "/bin/guix-daemon")
"--build-users-group" #$build-group
"--max-silent-time"
--8<---------------cut here---------------end--------------->8---
a Hurd VM built with
--8<---------------cut here---------------start------------->8---
./pre-inst-env guix system disk-image --target=i586-pc-gnu gnu/system/examples/bare-hurd.tmpl
--8<---------------cut here---------------end--------------->8---
has the shepherd starting the guix-daemon fine.
I found that the /container bit was added in
8ce6f4dc2879919c12bc76a2f4b01200af97e019
installer: Run the installation inside a container.
...but I don't find the commit message quite clear about its intention
to *always* run guix-daemon in a container; it could be read as
sugessting to do so only during installation?
How to proceed reverting this container feature for the Hurd?
Greetings,
Janneke
*) For the Hurd that currently is something like:
GUIX_LOCPATH=/gnu/store/z7a6sbvqzb5zapwpznmjkq2rsxil6i67-glibc-utf8-locales-2.31/lib/locale\
LC_ALL=en_US.utf8\
guix-daemon --build-users-group guixbuild --max-silent-time 0 --timeout 0
--log-compression bzip2 --substitute-urls https://ci.guix.gnu.org
--disable-chroot --disable-deduplication
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#43533: guix-daemon fails to start in Childhurd
2020-09-20 15:05 bug#43533: guix-daemon fails to start in Childhurd Jan Nieuwenhuizen
@ 2020-09-21 8:30 ` Mathieu Othacehe
2020-09-21 8:41 ` Jan Nieuwenhuizen
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2020-09-21 8:30 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 43533-done
Hello janneke,
> 8ce6f4dc2879919c12bc76a2f4b01200af97e019
> installer: Run the installation inside a container.
>
> ...but I don't find the commit message quite clear about its intention
> to *always* run guix-daemon in a container; it could be read as
> sugessting to do so only during installation?
Thanks for the detailed bug report. Yes it's not very clear, I'll try to
improve the comments. The idea is that when you run:
herd start guix-daemon PID
then, the guix-daemon joins the given PID namespaces, which is practical
to solve an installation issue.
If guix-daemon is started normally, outside of the installation process,
then it joins the caller namespaces, which should be a no-op. Of course,
it breaks everything if the operating system does not support
namespaces.
Fixed with 6453915cf7729203ef9552c13cb4528c6f4ed122.
Sorry for the breakage,
Mathieu
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#43533: guix-daemon fails to start in Childhurd
2020-09-21 8:30 ` Mathieu Othacehe
@ 2020-09-21 8:41 ` Jan Nieuwenhuizen
0 siblings, 0 replies; 3+ messages in thread
From: Jan Nieuwenhuizen @ 2020-09-21 8:41 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 43533-done
Mathieu Othacehe writes:
Hello Mathieu,
>> 8ce6f4dc2879919c12bc76a2f4b01200af97e019
>> installer: Run the installation inside a container.
>>
>> ...but I don't find the commit message quite clear about its intention
>> to *always* run guix-daemon in a container; it could be read as
>> sugessting to do so only during installation?
>
> Thanks for the detailed bug report. Yes it's not very clear, I'll try to
> improve the comments. The idea is that when you run:
>
> herd start guix-daemon PID
>
> then, the guix-daemon joins the given PID namespaces, which is practical
> to solve an installation issue.
>
> If guix-daemon is started normally, outside of the installation process,
> then it joins the caller namespaces, which should be a no-op. Of course,
> it breaks everything if the operating system does not support
> namespaces.
>
> Fixed with 6453915cf7729203ef9552c13cb4528c6f4ed122.
Yay, I can confirm that it works!
> Sorry for the breakage,
Thanks for the quick fix and explanation, I didn't catch that no-op
trick! It's all about context/knowledge I guess; If you know how /ns/
works, I guess that the patch/explanation was clear.
Greetings,
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-21 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 15:05 bug#43533: guix-daemon fails to start in Childhurd Jan Nieuwenhuizen
2020-09-21 8:30 ` Mathieu Othacehe
2020-09-21 8:41 ` Jan Nieuwenhuizen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).