unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#33897: 'guix publish' is unable to serve narinfos for dead items
@ 2018-12-28 21:49 Ludovic Courtès
  2019-05-25 23:37 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2018-12-28 21:49 UTC (permalink / raw)
  To: 33897

Hello,

‘render-narinfo/cached’ in ‘guix publish’ uses ‘hash-part->path’ to go
from /xyz.narinfo to, say, /gnu/store/xyz-guile-2.2.4.

The problem is that ‘hash-part->path’ is an RPC that works only if xyz
corresponds to a live item; in other cases, it returns the empty
string.  Consequently, if /gnu/store/xyz-guile-2.2.4 has been GC’d,
‘guix publish’ returns 404 for /xyz.narinfo, even if it actually has the
narinfo somewhere in cache.

This defeats the intended behavior of ‘--cache’ and ‘--ttl’.

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#33897: 'guix publish' is unable to serve narinfos for dead items
  2018-12-28 21:49 bug#33897: 'guix publish' is unable to serve narinfos for dead items Ludovic Courtès
@ 2019-05-25 23:37 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2019-05-25 23:37 UTC (permalink / raw)
  To: 33897-done

Ludovic Courtès <ludo@gnu.org> skribis:

> ‘render-narinfo/cached’ in ‘guix publish’ uses ‘hash-part->path’ to go
> from /xyz.narinfo to, say, /gnu/store/xyz-guile-2.2.4.
>
> The problem is that ‘hash-part->path’ is an RPC that works only if xyz
> corresponds to a live item; in other cases, it returns the empty
> string.  Consequently, if /gnu/store/xyz-guile-2.2.4 has been GC’d,
> ‘guix publish’ returns 404 for /xyz.narinfo, even if it actually has the
> narinfo somewhere in cache.
>
> This defeats the intended behavior of ‘--cache’ and ‘--ttl’.

Fixed in 493375cdb23fc1416348da584f17bec7171faadd.

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-25 23:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 21:49 bug#33897: 'guix publish' is unable to serve narinfos for dead items Ludovic Courtès
2019-05-25 23:37 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).