From: "Ludovic Courtès" <ludo@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 42212@debbugs.gnu.org
Subject: bug#42212: [PATCH 1/1] self: Use nearest tag as the version string in documentation.
Date: Mon, 20 Jul 2020 10:13:34 +0200 [thread overview]
Message-ID: <87r1t6zjrl.fsf@gnu.org> (raw)
In-Reply-To: <20200717235503.19809-2-arunisaac@systemreboot.net> (Arun Isaac's message of "Sat, 18 Jul 2020 05:25:03 +0530")
Hi Arun,
Arun Isaac <arunisaac@systemreboot.net> skribis:
> * guix/channels.scm (latest-channel-instance): Write nearest tag into .version
> of the checkout.
> * guix/self.scm (info-manual): Use nearest tag from .version as the version
> string while generating documentation.
Thanks for looking into it! Two comments:
> + ;; Write nearest tag into .version.
> + (with-directory-excursion checkout
> + (let ((version
> + (call-with-port
> + (open-pipe* OPEN_READ "./build-aux/git-version-gen" ".tarball-version")
> + get-string-all)))
> + (call-with-output-file ".version"
> + (cut put-string <> version)))))
>
> (let* ((name (url+commit->name (channel-url channel) commit))
> (checkout (add-to-store store name #t "sha256" checkout
I would rather not call out to ‘git-version-gen’ and instead use (git
describe) or similar.
However, unless I’m mistaken, the output of ‘git-version-gen’ changes at
each commit, so we’d be rebuilding the manual at every commit, which is
what we should avoid here.
One way to avoid that would be to look at the latest commit that touch
doc/ instead of the latest commit overall (I think that’s what zimoun
was suggesting). Roughly run ‘git describe’ on ‘git log doc/’, so to
speak. (Using Guile-Git.)
Thoughts?
Ludo’.
next prev parent reply other threads:[~2020-07-20 8:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 7:59 bug#42212: Guix version rendered as 0.0-git in info manual Arun Isaac
2020-07-09 22:29 ` Ludovic Courtès
2020-07-15 21:42 ` Arun Isaac
2020-07-15 23:26 ` Ludovic Courtès
2020-07-16 0:46 ` Bengt Richter
2020-07-16 5:08 ` Bengt Richter
2020-07-16 10:06 ` zimoun
2020-07-16 9:37 ` zimoun
2020-07-16 9:48 ` Ludovic Courtès
2020-07-16 10:19 ` zimoun
2020-07-16 19:36 ` Efraim Flashner
2020-07-17 23:55 ` bug#42212: [PATCH 0/1] Use nearest tag as the version string in documentation Arun Isaac
2020-07-17 23:55 ` bug#42212: [PATCH 1/1] self: " Arun Isaac
2020-07-20 8:13 ` Ludovic Courtès [this message]
2020-07-20 8:36 ` Arun Isaac
2020-07-20 12:32 ` Ludovic Courtès
2020-07-20 13:42 ` zimoun
2020-07-27 23:13 ` bug#42212: [PATCH v2 0/1] " Arun Isaac
2020-07-27 23:13 ` bug#42212: [PATCH v2 1/1] " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1t6zjrl.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42212@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).