From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yAnSLlJSFV90dgAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 08:14:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wDy/KlJSFV+DIwAA1q6Kng (envelope-from ) for ; Mon, 20 Jul 2020 08:14:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 391F59401CD for ; Mon, 20 Jul 2020 08:14:10 +0000 (UTC) Received: from localhost ([::1]:48370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxQw4-0003dw-0Y for larch@yhetil.org; Mon, 20 Jul 2020 04:14:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxQvy-0003dq-36 for bug-guix@gnu.org; Mon, 20 Jul 2020 04:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxQvx-0000KJ-Qe for bug-guix@gnu.org; Mon, 20 Jul 2020 04:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxQvx-00016y-Mg for bug-guix@gnu.org; Mon, 20 Jul 2020 04:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42212: [PATCH 1/1] self: Use nearest tag as the version string in documentation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 20 Jul 2020 08:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42212 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Arun Isaac Received: via spool by 42212-submit@debbugs.gnu.org id=B42212.15952328284244 (code B ref 42212); Mon, 20 Jul 2020 08:14:01 +0000 Received: (at 42212) by debbugs.gnu.org; 20 Jul 2020 08:13:48 +0000 Received: from localhost ([127.0.0.1]:33676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxQvk-00016N-B3 for submit@debbugs.gnu.org; Mon, 20 Jul 2020 04:13:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxQvg-000167-QP for 42212@debbugs.gnu.org; Mon, 20 Jul 2020 04:13:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58185) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxQvZ-0000J6-Pz; Mon, 20 Jul 2020 04:13:37 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=56426 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxQvY-0006JP-NL; Mon, 20 Jul 2020 04:13:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200716193629.GJ10256@E5400> <20200717235503.19809-2-arunisaac@systemreboot.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Thermidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 20 Jul 2020 10:13:34 +0200 In-Reply-To: <20200717235503.19809-2-arunisaac@systemreboot.net> (Arun Isaac's message of "Sat, 18 Jul 2020 05:25:03 +0530") Message-ID: <87r1t6zjrl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42212@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ynvXW3X6cl/h Hi Arun, Arun Isaac skribis: > * guix/channels.scm (latest-channel-instance): Write nearest tag into .ve= rsion > of the checkout. > * guix/self.scm (info-manual): Use nearest tag from .version as the versi= on > string while generating documentation. Thanks for looking into it! Two comments: > + ;; Write nearest tag into .version. > + (with-directory-excursion checkout > + (let ((version > + (call-with-port > + (open-pipe* OPEN_READ "./build-aux/git-version-gen" ".ta= rball-version") > + get-string-all))) > + (call-with-output-file ".version" > + (cut put-string <> version))))) >=20=20 > (let* ((name (url+commit->name (channel-url channel) commit)) > (checkout (add-to-store store name #t "sha256" checkout I would rather not call out to =E2=80=98git-version-gen=E2=80=99 and instea= d use (git describe) or similar. However, unless I=E2=80=99m mistaken, the output of =E2=80=98git-version-ge= n=E2=80=99 changes at each commit, so we=E2=80=99d be rebuilding the manual at every commit, whic= h is what we should avoid here. One way to avoid that would be to look at the latest commit that touch doc/ instead of the latest commit overall (I think that=E2=80=99s what zimo= un was suggesting). Roughly run =E2=80=98git describe=E2=80=99 on =E2=80=98gi= t log doc/=E2=80=99, so to speak. (Using Guile-Git.) Thoughts? Ludo=E2=80=99.