From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: Nils Landt <nils@landt.email>
Cc: 66659@debbugs.gnu.org
Subject: bug#66659: (home-)on-first-login script broken when no gexps are added
Date: Sat, 21 Oct 2023 20:27:12 +1100 [thread overview]
Message-ID: <87pm18codq.fsf@zancanaro.id.au> (raw)
In-Reply-To: <1084731920.55297.1697868845432@office.mailbox.org>
On Sat, Oct 21 2023, Nils Landt wrote:
> ...
> As you can see, there is no body in the "when" expression.
>
> Code in gnu/home/services.scm:438 :
>
> (if (file-exists? xdg-runtime-dir)
> (when (claim-first-run flag-file-path)
> #$@gexps)
>
> In my case, it appears that gexps is empty, resulting in the invalid syntax.
Ah, yep, that's an issue. That issue was introduced in 6b0a32196982a0a2f4dbb59d35e55833a5545ac6.
I guess this raises a question about how to resolve this: if we have no gexps, do we still want to claim the first run?
If yes: we can add #t (or whatever) to the end of the "when" form to make sure it's never empty.
If no: we can generate an empty on-first-login script that does nothing.
The previous behaviour was to still claim the first run, so I'll send through a patch that does that.
Carlo
next prev parent reply other threads:[~2023-10-21 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 6:14 bug#66659: (home-)on-first-login script broken when no gexps are added Nils Landt
2023-10-21 9:27 ` Carlo Zancanaro [this message]
2023-10-21 9:39 ` bug#66659: [PATCH] home: services: Don't crash on-first-login when nothing to do Carlo Zancanaro
2023-10-21 14:15 ` bug#66659: (home-)on-first-login script broken when no gexps are added Ludovic Courtès
[not found] ` <handler.66659.D66659.169789774918233.notifdone@debbugs.gnu.org>
2023-10-24 10:05 ` bug#66659: closed (Re: bug#66659: (home-)on-first-login script broken when no gexps are added) Nils Landt
2023-10-24 23:19 ` bug#66659: (home-)on-first-login script broken when no gexps are added Clément Lassieur
2023-10-27 22:22 ` Ludovic Courtès
2023-10-24 14:17 ` Rostislav Svoboda
2023-10-27 14:53 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm18codq.fsf@zancanaro.id.au \
--to=carlo@zancanaro.id.au \
--cc=66659@debbugs.gnu.org \
--cc=nils@landt.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).