From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aAVODcmaM2VqQAAA9RJhRA:P1 (envelope-from ) for ; Sat, 21 Oct 2023 11:32:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aAVODcmaM2VqQAAA9RJhRA (envelope-from ) for ; Sat, 21 Oct 2023 11:32:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C6D5408AD for ; Sat, 21 Oct 2023 11:32:55 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=Vz52M1oM; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697880777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wRX+JI7jzNXW3TkmcvOq8/46CN23KedZ9vVjR/y3MK8=; b=aTeKHkDgg4jCa6lh5Xpq+hX2pdTFyqF+zSTP6RWqdvKKhccOnPj9QLDUDubMpQ+eYUN3ud YU/sFC6wsKGyzXeeozH3Z4G/+Gaabf9aYUC1LrkKTITHniS7JF+N2pW0EUt40mmFLgghOk ZmgCZBMPhTZyJ1RuHlyCXXKLSPRQda585fuNYzRf5ojzRCRD2ttJMQDuyM1UFumP8688US aWlk4Efx/O7kEhe70LEWYFGKbbEG9Y5R8IRTED11ytZx4xZFXN58VFJIvZ+dX8980udJDa OrPfOZjPCrWIOVc3sk3ey2pNZb5dHE8G5zVG6HRffU0ZRBo3W3oQ1WAdPoQkzw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697880777; a=rsa-sha256; cv=none; b=fpRFtAY8gHN9nKyhm/3j11HF8806MSP0zOtRbq+1EbJIPPolFguDhIQLt1GyCF7dLdsN/3 B/y+bWCULDXAmgBEn3vbTktZiC3rAIDfHuU2yAfLKdBlmdOBP65Ji9UMF0397AadPmYk9z I+VW99cwsnaETtdGAO052e+rF8NNL9hbceSh/47viNUngksY4XlWOoT8ujU5QhbA7xJ0Nh YQ5LXScjntdzg23KpD6OOom4Y6u9p6ycAjiPnLFXR4uy+iPcv2n8WfKgft1QmAi+B6o4hz h3h6vbhY3Y5m2qkJ9PUB137eTRcqU031fT4a1vWKdaXD8NmpQ9ksFjvDR69RBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=Vz52M1oM; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu8LW-0005eh-62; Sat, 21 Oct 2023 05:32:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu8LT-0005eR-Vt for bug-guix@gnu.org; Sat, 21 Oct 2023 05:32:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu8LS-0004nM-Oc for bug-guix@gnu.org; Sat, 21 Oct 2023 05:32:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu8Lu-0007B3-DO for bug-guix@gnu.org; Sat, 21 Oct 2023 05:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66659: (home-)on-first-login script broken when no gexps are added Resent-From: Carlo Zancanaro Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 21 Oct 2023 09:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66659 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Nils Landt Cc: 66659@debbugs.gnu.org Received: via spool by 66659-submit@debbugs.gnu.org id=B66659.169788076927567 (code B ref 66659); Sat, 21 Oct 2023 09:33:02 +0000 Received: (at 66659) by debbugs.gnu.org; 21 Oct 2023 09:32:49 +0000 Received: from localhost ([127.0.0.1]:42210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8Ld-0007AW-Cv for submit@debbugs.gnu.org; Sat, 21 Oct 2023 05:32:49 -0400 Received: from voltorb.zancanaro.id.au ([45.77.50.64]:44154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8LX-0007AC-9L for 66659@debbugs.gnu.org; Sat, 21 Oct 2023 05:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=wRX+JI7jzNXW3Tk mcvOq8/46CN23KedZ9vVjR/y3MK8=; h=in-reply-to:date:subject:cc:to:from: references; d=zancanaro.id.au; b=Vz52M1oMSCCG96TJRNgw1QTeYXV5J+H6YUUmG PQrsEp51RloL16EjP03Ujr9fihznm9h8phfNY7vbm6HOjVUnYLlXkDZBB3DoyxEDoarMqD qPvL+v4NlBsvUbISr8tJ+F2HMJY+4XNueX5ogdr/s87cwruJrlA0mcXIlrTclfIU= Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id e8bedfb4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 21 Oct 2023 09:31:38 +0000 (UTC) References: <1084731920.55297.1697868845432@office.mailbox.org> User-agent: mu4e 1.10.7; emacs 29.1 From: Carlo Zancanaro Date: Sat, 21 Oct 2023 20:27:12 +1100 In-reply-to: <1084731920.55297.1697868845432@office.mailbox.org> Message-ID: <87pm18codq.fsf@zancanaro.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 5.00 X-Migadu-Queue-Id: 3C6D5408AD X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 5.00 X-TUID: uNsIlkbLDGun On Sat, Oct 21 2023, Nils Landt wrote: > ... > As you can see, there is no body in the "when" expression. > > Code in gnu/home/services.scm:438 : > > (if (file-exists? xdg-runtime-dir) > (when (claim-first-run flag-file-path) > #$@gexps) > > In my case, it appears that gexps is empty, resulting in the invalid syntax. Ah, yep, that's an issue. That issue was introduced in 6b0a32196982a0a2f4dbb59d35e55833a5545ac6. I guess this raises a question about how to resolve this: if we have no gexps, do we still want to claim the first run? If yes: we can add #t (or whatever) to the end of the "when" form to make sure it's never empty. If no: we can generate an empty on-first-login script that does nothing. The previous behaviour was to still claim the first run, so I'll send through a patch that does that. Carlo