bug#40682: frozen installer in WiFi section -guix 1.1.0

bug#40682: frozen installer in WiFi section -guix 1.1.0

[SergioBG BG]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Hi, the installer frozen when connect with wifi.
The driver ath9k_htc is loaded but the installer is frozen.
Does not ask for the wifi password.
Sorry for my english.

[-- Attachment #2: Type: text/html, Size: 219 bytes --]

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Ludovic Courtès]

Hi SergioBG,

SergioBG BG <sergiobgar@gmail.com> skribis:

> Hi, the installer frozen when connect with wifi.
> The driver ath9k_htc is loaded but the installer is frozen.
> Does not ask for the wifi password.

Could you send a picture of the installer WiFi screen when it’s frozen?

Could you then hit ctrl-alt-f12 and take a picture of what’s printed
there?

> Sorry for my english.

No problem.  If you prefer you can write in French, German, or Spanish
and someone will be able to answer you (developers speak other languages
too but these are the most common.)

Thanks,
Ludo’.

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi,

SergioBG BG <sergiobgar@gmail.com> skribis:

> Here the screenshot of Frozen.

Thanks.  Looking at the screenshot, it would seem that the installer is
stuck somewhere in ‘connman-connect-with-auth’, but it’s hard to tell
why/where.

I was able to reproduce it in ‘guix system vm’ with the patch below.

Cc: Mathieu in case they have an idea…

To be continued…

Thanks,
Ludo’.

PS: Nyacc contains libdbus bindings as an example of its FFI tooling,
    perhaps we should give it a try and use it here.  It could be more
    robust than piping through ‘connmanctl’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2643 bytes --]

diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index 0965c4d237..826f6d356d 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -322,6 +322,52 @@ the user's target storage device rather than on the RAM disk."
     "Load the @code{uvesafb} kernel module with the right options.")
    (default-value #t)))
 
+(define (simulated-wifi-shepherd-services hostapd)
+  (define config
+    (plain-file "hostapd.conf" "\
+interface=wlan1
+ssid=Test Net
+channel=1\n"))
+
+  (list (shepherd-service
+         (provision '(hostapd))
+         (requirement '(mac-sim-module unblocked-wifi))
+         (start #~(make-forkexec-constructor
+                   (list #$(file-append hostapd "/sbin/hostapd")
+                         #$config)
+                   #:log-file "/var/log/hostapd.log"))
+         (stop #~(make-kill-destructor)))
+        (shepherd-service
+         (provision '(unblocked-wifi))
+         (requirement '(mac-sim-module))
+         (start #~(lambda _
+                    (invoke #$(file-append util-linux "/sbin/rfkill")
+                            "unblock" "0")
+                    (invoke #$(file-append util-linux "/sbin/rfkill")
+                            "unblock" "1")))
+         (one-shot? #t))
+        (shepherd-service
+         (provision '(mac-sim-module))
+         (requirement '(term-tty3))
+         (modules '((guix build utils)))
+         (start #~(lambda _
+                    ;; XXX: We can't use 'load-linux-module*' here because it
+                    ;; expects a flat module directory.
+                    (setenv "LINUX_MODULE_DIRECTORY"
+                            "/run/booted-system/kernel/lib/modules")
+                    (invoke #$(file-append kmod "/bin/modprobe")
+                            "mac80211_hwsim")))
+         (one-shot? #t))))
+
+(define simulated-wifi-service-type
+  (service-type
+   (name 'simulated-wifi)
+   (extensions
+    (list (service-extension shepherd-root-service-type
+                             simulated-wifi-shepherd-services)))
+   (default-value hostapd)
+   (description "Run hostapd to simulate WiFi connectivity.")))
+
 (define %installation-services
   ;; List of services of the installation system.
   (let ((motd (plain-file "motd" "
@@ -366,6 +412,8 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m
           ;; The usual services.
           (syslog-service)
 
+          (service simulated-wifi-service-type)
+
           ;; The build daemon.  Register the default substitute server key(s)
           ;; as trusted to allow the installation process to use substitutes by
           ;; default.

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Mathieu Othacehe]

Hey,

I believe this is fixed by ea6594e0 on master.

This is indeed very fragile, and converting it to D-Bus would be the
right move. I will have a look to Nyacc! Writing a clean Guile-Dbus
library could also be a nice and valuable GSoC/Outreachy project.

In the meantime, could we merge your patch so that we have a hidden
simulated Wifi network available, that can be used in the installer
tests?

Thanks,

Mathieu

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Ludovic Courtès]

Hi,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> I believe this is fixed by ea6594e0 on master.

Good catch!

> This is indeed very fragile, and converting it to D-Bus would be the
> right move. I will have a look to Nyacc! Writing a clean Guile-Dbus
> library could also be a nice and valuable GSoC/Outreachy project.

Yes, it would be ideal to have a pure-Scheme implementation, but in the
meantime, perhaps generated bindings via Nyacc could work well enough.

> In the meantime, could we merge your patch so that we have a hidden
> simulated Wifi network available, that can be used in the installer
> tests?

I’ve now pushed it as two proper service types: ‘hostapd-service-type’
and ‘simulated-wifi-service-type’, the latter using parts of the former.

Note that currently the installer tests bypass connectivity checks
altogether, but perhaps we can still check what comes before, namely
network selection?

Thanks,
Ludo’.

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Mathieu Othacehe]

Hey,

> I’ve now pushed it as two proper service types: ‘hostapd-service-type’
> and ‘simulated-wifi-service-type’, the latter using parts of the former.
>
> Note that currently the installer tests bypass connectivity checks
> altogether, but perhaps we can still check what comes before, namely
> network selection?

Yes, maybe we can skip only the connectivity check but still try to
connect to some network. I will have a look later this week.

Almost unrelated topic, it would be nice to provide an interface where
users can grab a nightly/periodic build of the installer and test the
latest fixes. We are already have "usb-image" and "iso9660-image" jobs
in Cuirass. So it could be a link allowing to download the latest
successful build or so.

Thanks,

Mathieu

bug#40682: frozen installer in WiFi section -guix 1.1.0

[SergioBG BG]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

This is good idea for users.

El lun., 20 abr. 2020 a las 19:20, Mathieu Othacehe (<m.othacehe@gmail.com>)
escribió:

>
> Hey,
>
> > I’ve now pushed it as two proper service types: ‘hostapd-service-type’
> > and ‘simulated-wifi-service-type’, the latter using parts of the former.
> >
> > Note that currently the installer tests bypass connectivity checks
> > altogether, but perhaps we can still check what comes before, namely
> > network selection?
>
> Yes, maybe we can skip only the connectivity check but still try to
> connect to some network. I will have a look later this week.
>
> Almost unrelated topic, it would be nice to provide an interface where
> users can grab a nightly/periodic build of the installer and test the
> latest fixes. We are already have "usb-image" and "iso9660-image" jobs
> in Cuirass. So it could be a link allowing to download the latest
> successful build or so.
>
> Thanks,
>
> Mathieu
>

[-- Attachment #2: Type: text/html, Size: 1330 bytes --]

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Ludovic Courtès]

Hi,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> Almost unrelated topic, it would be nice to provide an interface where
> users can grab a nightly/periodic build of the installer and test the
> latest fixes. We are already have "usb-image" and "iso9660-image" jobs
> in Cuirass. So it could be a link allowing to download the latest
> successful build or so.

Yes, it would be nice.  We’d need to allow Cuirass to somehow publish
raw files, like Hydra does.

Ludo’.

bug#40682: Installer hangs while connecting to WiFi network

[Jacek Podkanski via web]

Can you tell the user to connect to the network manually instead of getting stuck at graphical wifi connection? That would allow to bypass the problem and continue with the installation.

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Leo Famulari]

What is the status of this bug?

If we have a fix, can we make a new installer image? There are people on
#guix having trouble getting online in the installer, and I think they
are hitting this issue.

bug#40682: frozen installer in WiFi section -guix 1.1.0

[Mathieu Othacehe]

Hey Leo,

> If we have a fix, can we make a new installer image? There are people on
> #guix having trouble getting online in the installer, and I think they
> are hitting this issue.

This bug has been fixed with ea6594e0. However, I left the ticket open
because I'm supposed to add some testing using the hostapd service Ludo
proposed.

Regarding providing a new image, I proposed a patch here[1] so that
Cuirass can host fresh installation images built upon master.

Thanks,

Mathieu

[1]: https://lists.gnu.org/archive/html/guix-patches/2020-05/msg00001.html

bug#40682: Installer hangs while connecting to WiFi network

[Ricardo Wurmus via web]

Alternative URL: https://issues.guix.gnu.org/40993

bug#40682: Installer hangs while connecting to WiFi network

[Maxim Cournoyer]

Hello,

Mathieu Othacehe <othacehe@gnu.org> writes:

> Hey Leo,
>
>> If we have a fix, can we make a new installer image? There are people on
>> #guix having trouble getting online in the installer, and I think they
>> are hitting this issue.
>
> This bug has been fixed with ea6594e0. However, I left the ticket open
> because I'm supposed to add some testing using the hostapd service Ludo
> proposed.

Are these still in your plans?  Otherwise let's close this old,
high severity bug.

> Regarding providing a new image, I proposed a patch here[1] so that
> Cuirass can host fresh installation images built upon master.

This has been implemented for a while, congrats!

-- 
Thanks,
Maxim

bug#40682: Installer hangs while connecting to WiFi network

[zimoun]

Hi,

On Fri, 07 Oct 2022 at 23:07, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

>> This bug has been fixed with ea6594e0. However, I left the ticket open
>> because I'm supposed to add some testing using the hostapd service Ludo
>> proposed.
>
> Are these still in your plans?  Otherwise let's close this old,
> high severity bug.

Friendly ping. :-)


Cheers,
simon

bug#40682: Installer hangs while connecting to WiFi network

[Mathieu Othacehe]

Hey,

>> Are these still in your plans?  Otherwise let's close this old,
>> high severity bug.
>
> Friendly ping. :-)

Yeah, we didn't have other reports regarding WiFi connections, so lets
close it.

Thanks,

Mathieu