From: Simon Tournier <zimon.toutoune@gmail.com>
To: Andreas Enge <andreas@enge.fr>
Cc: 62954@debbugs.gnu.org
Subject: bug#62954: Valgrind blocks R on powerpc64le
Date: Thu, 20 Apr 2023 14:35:42 +0200 [thread overview]
Message-ID: <87o7nid941.fsf@gmail.com> (raw)
In-Reply-To: <ZEEm+k0zvdjripae@jurong> (Andreas Enge's message of "Thu, 20 Apr 2023 13:50:18 +0200")
Hi,
On jeu., 20 avril 2023 at 13:50, Andreas Enge <andreas@enge.fr> wrote:
> So subversion depends on valgrind! And all new simplex-texlive-packages
> are concerned.
Good catch! :-)
> I think the solution is to indeed remove valgrind from the native inputs
> of lz4.
Yeah, and I think it’s safe. :-) Considering,
--8<---------------cut here---------------start------------->8---
starting phase `check'
CFLAGS="" LDFLAGS="" make -C tests test
--8<---------------cut here---------------end--------------->8---
and the ’test’ suite reads,
--8<---------------cut here---------------start------------->8---
$ grep '^test:' $(./pre-inst-env guix build lz4 -S)/tests/Makefile
test: test-lz4 test-lz4c test-frametest test-fullbench test-fuzzer test-install test-amalgamation listTest test-decompress-partial
--8<---------------cut here---------------end--------------->8---
Last, ’valgrind’ appears only in this rule:
--8<---------------cut here---------------start------------->8---
test-mem: lz4 datagen fuzzer frametest fullbench
@echo "\n ---- valgrind tests : memory analyzer ----"
valgrind --leak-check=yes --error-exitcode=1 $(DATAGEN) -g50M > $(VOID)
$(DATAGEN) -g16KB > ftmdg16K
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) -9 -BD -f ftmdg16K $(VOID)
$(DATAGEN) -g16KB -s2 > ftmdg16K2
$(DATAGEN) -g16KB -s3 > ftmdg16K3
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) --force --multiple ftmdg16K ftmdg16K2 ftmdg16K3
$(DATAGEN) -g7MB > ftmdg7M
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) -9 -B5D -f ftmdg7M ftmdg16K2
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) -t ftmdg16K2
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) -bi1 ftmdg7M
valgrind --leak-check=yes --error-exitcode=1 ./fullbench -i1 ftmdg7M ftmdg16K2
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) -B4D -f -vq ftmdg7M $(VOID)
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) --list -m ftm*.lz4
valgrind --leak-check=yes --error-exitcode=1 $(LZ4) --list -m -v ftm*.lz4
$(RM) ftm*
valgrind --leak-check=yes --error-exitcode=1 ./fuzzer -i64 -t1
valgrind --leak-check=yes --error-exitcode=1 ./frametest -i256
--8<---------------cut here---------------end--------------->8---
so ’valgrind’ is never used by the current recipe. Ahah! :-D
And it’s confirmed: lz4 builds fine on core-updates for x68_64.
Therefore, I think this change before the merge is worth:
--8<---------------cut here---------------start------------->8---
1 file changed, 1 insertion(+), 5 deletions(-)
gnu/packages/compression.scm | 6 +-----
modified gnu/packages/compression.scm
@@ -840,11 +840,7 @@ (define-public lz4
(build-system gnu-build-system)
(outputs (list "out" "static"))
(native-inputs
- (append
- (list python) ;; For tests.
- (if (member (%current-system) (package-supported-systems valgrind))
- (list valgrind)
- '())))
+ (list python))
(arguments
`(;; Not designed for parallel testing.
;; See https://github.com/lz4/lz4/issues/957#issuecomment-737419821
--8<---------------cut here---------------end--------------->8---
Cheers,
simon
next prev parent reply other threads:[~2023-04-20 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 20:08 bug#62954: Valgrind blocks R on powerpc64le Andreas Enge
2023-04-20 11:26 ` Simon Tournier
2023-04-20 11:50 ` Andreas Enge
2023-04-20 12:35 ` Simon Tournier [this message]
2023-04-20 13:25 ` Simon Tournier
2023-04-20 16:55 ` Andreas Enge
2023-04-21 7:59 ` Simon Tournier
2023-04-21 8:37 ` Andreas Enge
2023-04-25 15:24 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7nid941.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=62954@debbugs.gnu.org \
--cc=andreas@enge.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).