From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qENWMUgyQWSwgAAASxT56A (envelope-from ) for ; Thu, 20 Apr 2023 14:38:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IMw8MUgyQWQp2QAA9RJhRA (envelope-from ) for ; Thu, 20 Apr 2023 14:38:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88A1C4A8 for ; Thu, 20 Apr 2023 14:38:32 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppTWn-0001uv-4A; Thu, 20 Apr 2023 08:36:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppTWM-0001oj-GE for bug-guix@gnu.org; Thu, 20 Apr 2023 08:36:18 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppTW6-0005Ex-Bz for bug-guix@gnu.org; Thu, 20 Apr 2023 08:36:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppTW6-0003QG-47 for bug-guix@gnu.org; Thu, 20 Apr 2023 08:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#62954: Valgrind blocks R on powerpc64le Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 20 Apr 2023 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62954 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Andreas Enge Cc: 62954@debbugs.gnu.org Received: via spool by 62954-submit@debbugs.gnu.org id=B62954.168199415313141 (code B ref 62954); Thu, 20 Apr 2023 12:36:02 +0000 Received: (at 62954) by debbugs.gnu.org; 20 Apr 2023 12:35:53 +0000 Received: from localhost ([127.0.0.1]:36799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppTVw-0003Ps-G9 for submit@debbugs.gnu.org; Thu, 20 Apr 2023 08:35:52 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppTVu-0003Pe-TH for 62954@debbugs.gnu.org; Thu, 20 Apr 2023 08:35:51 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-2f4d0fc8df4so113011f8f.0 for <62954@debbugs.gnu.org>; Thu, 20 Apr 2023 05:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681994145; x=1684586145; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=uuy0ODyDTNggjh8OmsmtQrK9wFR6WDS2/Y+qyoIx/tM=; b=O5b5Ev68C+xt65JCr5VCxWzjfNzDwmhui/Rw+CiqSXQ+8ItIp8nYYknY44og5sdEL2 i0K43hAr4Mf3GuEFWD6AyqL+/U1ATn/qwqaiX5BYsqARkqakaOChqAEhnWpl/rFNnks1 hW5jnCv3Zaei0uSiH90VCvkfwN6e3nP/YyTpOybrAra6xKQ+1IvVhAHiwYJxc8iCf/tM UP4pA8uFKMQTMlLYv0XivDFnmqXx0tFblrJByt6EZua5C1QBDfYRP3861ip9HX32hcNy Mj5b02/kjgPy9Av6M628gosDUYzpPcZv2wI/j4YAIdR1KToPR01K+2bO2uULNlyX5TB2 BPEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681994145; x=1684586145; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uuy0ODyDTNggjh8OmsmtQrK9wFR6WDS2/Y+qyoIx/tM=; b=fKtUUClMqxeZiKlsQsY4nP5O7aWDz1WGdP9Vyw6VEB4UUK3Giy8biE9BHD30hkjjJe MeNGLCqR32Ar0UDC7HEZeb9oeNrSDBuA3GKTm1Hz96K0Pqu7DEy+G9T08f+HRnZKk2Qk XO2JmxFUpxQ0INREt80D9du5TXyWHm9UDTeZg/zT8glQL96Q/tI+i1j0JZuyWJ60Cmvc sAkbmfhesW/z/fi+Ghq1CY3G9NNJA+ZOGlP5t1cJp4/IMKvBlYwRARiUBsBbacZMq14Z DsPqbhUgGAc8ZnGtXdDYuUkdb95E6ea3GUnifcknCo04T/+A9LfAE6ydvK/KOFboF7Nt BWyw== X-Gm-Message-State: AAQBX9fBr4lw+K5EbJSBtxCn8yfwdyBBXcOIHap8OskJUILwLkiu57lh rBGfd5VuO/xKr8l3M1rAHY411sloYQQ= X-Google-Smtp-Source: AKy350aCk2Ne+p+/E1+JQBD3SGeQtXvQ/v6DOWs26I1EQkCyrkl9Xu3Qrp9HPBmub7hnLVPRcYIn+w== X-Received: by 2002:a05:6000:185:b0:2f9:ee11:e5c3 with SMTP id p5-20020a056000018500b002f9ee11e5c3mr879584wrx.2.1681994145029; Thu, 20 Apr 2023 05:35:45 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id b4-20020a05600010c400b002e45f6ffe63sm1895932wrx.26.2023.04.20.05.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 05:35:44 -0700 (PDT) From: Simon Tournier References: <87r0sedcb6.fsf@gmail.com> Date: Thu, 20 Apr 2023 14:35:42 +0200 In-Reply-To: (Andreas Enge's message of "Thu, 20 Apr 2023 13:50:18 +0200") Message-ID: <87o7nid941.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681994312; a=rsa-sha256; cv=none; b=LnUfHdbn/SBiFvRLSd1aboDCsj1HAy3i4VzFDP7/ezKatJbz7WBwZic8KTWTf+Adlo2Y21 8ZiKQZbhmYUFggOUlP7sU9ZJtticyHAefpWU+hZSiK0izXPCVs1b22PLeeeySS3xaRXXJ0 95cudDV86j/fDvxudFdW0Zt2uYUisiSzA+ieug47zUYQPTPTh7kEOx5ZbhCqTGndWdzDgE WRjPoNFru3Kvb8eAzhp5jIQkphcJW4da0yh2McOt6Pn5X6WdXN8FhQTniTeAIl6ap6XqBe dIE9OwPoRvmEPbYD4jXFoFJrdyCQEyF0INJS5yLecJOYep2N2tFT+tRVLtdycg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=O5b5Ev68; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681994312; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uuy0ODyDTNggjh8OmsmtQrK9wFR6WDS2/Y+qyoIx/tM=; b=C9pfCQO6GyKANBx61whB8Neya2yMSr7i3WWjjiluC2IgoRBX01JNfiNQ66xnyX8rgPJBiL fU2SVPcOAl6LIQEoT/YaZbwtP3G8dk95F0TwTPBprvmjuDrcTt8lJPcUjwaG6VTswuD2p9 4739aJQKzN4LEQ31UGVI0GhZCGtC63UKqyuA1VtUS5clujqn1mCAesYFK2id0U+5TFGTmY W5LAZX4S2uY+s0tFh9sBG/URJ1BhIAyatsNV757eDu6sn0raWhv80SNkDJEmb9O/E+fntr bnIF30YLEnGI34Ks0G7h6XSQQCVvbBqpU8/jwmF4ZfZ8Q296nisGcauj5av/zw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.61 X-Spam-Score: -0.61 X-Migadu-Queue-Id: 88A1C4A8 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=O5b5Ev68; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: mvQ9ikrlLPBg Hi, On jeu., 20 avril 2023 at 13:50, Andreas Enge wrote: > So subversion depends on valgrind! And all new simplex-texlive-packages > are concerned. Good catch! :-) > I think the solution is to indeed remove valgrind from the native inputs > of lz4. Yeah, and I think it=E2=80=99s safe. :-) Considering, --8<---------------cut here---------------start------------->8--- starting phase `check' CFLAGS=3D"" LDFLAGS=3D"" make -C tests test --8<---------------cut here---------------end--------------->8--- and the =E2=80=99test=E2=80=99 suite reads, --8<---------------cut here---------------start------------->8--- $ grep '^test:' $(./pre-inst-env guix build lz4 -S)/tests/Makefile test: test-lz4 test-lz4c test-frametest test-fullbench test-fuzzer test-ins= tall test-amalgamation listTest test-decompress-partial --8<---------------cut here---------------end--------------->8--- Last, =E2=80=99valgrind=E2=80=99 appears only in this rule: --8<---------------cut here---------------start------------->8--- test-mem: lz4 datagen fuzzer frametest fullbench @echo "\n ---- valgrind tests : memory analyzer ----" valgrind --leak-check=3Dyes --error-exitcode=3D1 $(DATAGEN) -g50M > $(VOID) $(DATAGEN) -g16KB > ftmdg16K valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) -9 -BD -f ftmdg16K= $(VOID) $(DATAGEN) -g16KB -s2 > ftmdg16K2 $(DATAGEN) -g16KB -s3 > ftmdg16K3 valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) --force --multiple= ftmdg16K ftmdg16K2 ftmdg16K3 $(DATAGEN) -g7MB > ftmdg7M valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) -9 -B5D -f ftmdg7M= ftmdg16K2 valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) -t ftmdg16K2 valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) -bi1 ftmdg7M valgrind --leak-check=3Dyes --error-exitcode=3D1 ./fullbench -i1 ftmdg7M f= tmdg16K2 valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) -B4D -f -vq ftmdg7= M $(VOID) valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) --list -m ftm*.lz4 valgrind --leak-check=3Dyes --error-exitcode=3D1 $(LZ4) --list -m -v ftm*.= lz4 $(RM) ftm* valgrind --leak-check=3Dyes --error-exitcode=3D1 ./fuzzer -i64 -t1 valgrind --leak-check=3Dyes --error-exitcode=3D1 ./frametest -i256 --8<---------------cut here---------------end--------------->8--- so =E2=80=99valgrind=E2=80=99 is never used by the current recipe. Ahah! := -D And it=E2=80=99s confirmed: lz4 builds fine on core-updates for x68_64. Therefore, I think this change before the merge is worth: --8<---------------cut here---------------start------------->8--- 1 file changed, 1 insertion(+), 5 deletions(-) gnu/packages/compression.scm | 6 +----- modified gnu/packages/compression.scm @@ -840,11 +840,7 @@ (define-public lz4 (build-system gnu-build-system) (outputs (list "out" "static")) (native-inputs - (append - (list python) ;; For tests. - (if (member (%current-system) (package-supported-systems valgrind)) - (list valgrind) - '()))) + (list python)) (arguments `(;; Not designed for parallel testing. ;; See https://github.com/lz4/lz4/issues/957#issuecomment-737419821 --8<---------------cut here---------------end--------------->8--- Cheers, simon