bug#48018: ImageMagick’s ‘convert’ fails to delegate to ‘dwebp’

bug#48018: ImageMagick’s ‘convert’ fails to delegate to ‘dwebp’

[Ludovic Courtès]

ImageMagick’s ‘convert’ refers to the ‘dwebp’ program with a leading
space, which prevents conversion to/from webp:

--8<---------------cut here---------------start------------->8---
$ guix time-machine --commit=2a624253bc55e2a94f6581d6e790303575436c96 -- \
   environment -C --ad-hoc strace imagemagick libwebp -- \
   strace -f -e execve convert t.webp t.png
execve("/gnu/store/2rmnafvwqvl460qa370gn18yl09dx91h-profile/bin/convert", ["convert", "t.webp", "t.png"], 0x7ffe6637b988 /* 10 vars */) = 0
strace: Process 5 attached
[pid     5] execve("/gnu/store/2rmnafvwqvl460qa370gn18yl09dx91h-profile/bin/ dwebp", [" dwebp", "-pam", "/tmp/magick-FacyU5v0_s0CnpxpMzs0"..., "-o", "/tmp/magick-4R_OusxZBx5fjGrfq0KU"...], 0x7ffd7f3538e8 /* 10 vars */) = -1 ENOENT (No such file or directory)
[pid     5] +++ exited with 1 +++
--- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=5, si_uid=1000, si_status=1, si_utime=0, si_stime=0} ---
convert: unable to open image `t.webp': No such file or directory @ error/blob.c/OpenBlob/2924.
convert: delegate failed `' dwebp' -pam '%i' -o '%o'' @ error/delegate.c/InvokeDelegate/1970.
convert: unable to open file `/tmp/magick-e8GzrEcauG0mZICNZggy_vG77mtn29lu': No such file or directory @ error/constitute.c/ReadImage/615.
convert: no images defined `t.png' @ error/convert.c/ConvertImageCommand/3229.
+++ exited with 1 +++
--8<---------------cut here---------------end--------------->8---

Ludo’.

bug#48018: [PATCH core-updates 2/4] gnu: imagemagick: Fix converting webp images

[Saku Laesvuori via Bug reports for GNU Guix]

Fixes <https://issues.guix.gnu.org/48018>.

* gnu/packages/imagemagick.scm (imagemagick)[inputs]: Add libwebp.
---
The comments in the code imply that this could be applied to master, but
`guix refresh` claimed it to have over 3 000 dependents. Go figure.

 gnu/packages/imagemagick.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/imagemagick.scm b/gnu/packages/imagemagick.scm
index 169dc12f35..55e100a71c 100644
--- a/gnu/packages/imagemagick.scm
+++ b/gnu/packages/imagemagick.scm
@@ -158,6 +158,8 @@ (define-public imagemagick
                (base32
                 "0didbs10i9zb4dgripa851j7fivxb9jar7l3vvxz6i4kn6xvdv7r"))
               (patches (search-patches "imagemagick-Fix-tests.patch"))))
+    (inputs (cons `("libwebp" ,libwebp)
+                  (package-inputs imagemagick/stable)))
     (arguments
      (append (package-arguments imagemagick/stable)
              '(#:tests? #t)))))
-- 
2.41.0

bug#48018: reviewed, checked and re-based the previous commit

[Wicki Gabriel (wicg)]

[-- Attachment #1.1: Type: text/plain, Size: 134 bytes --]

I've checked the patch above which works like a charm.  I've created a new patch.  Please credit the original author before merging.

[-- Attachment #1.2: Type: text/html, Size: 544 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Fix-imagemagick-webp-related-failures.patch --]
[-- Type: text/x-patch; name="0001-gnu-Fix-imagemagick-webp-related-failures.patch", Size: 1125 bytes --]

From 37faa5cac3545406721cfaaf4b2f97841a889510 Mon Sep 17 00:00:00 2001
Message-ID: <37faa5cac3545406721cfaaf4b2f97841a889510.1699268702.git.wicg@zhaw.ch>
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Mon, 6 Nov 2023 12:01:47 +0100
Subject: [PATCH] gnu: Fix imagemagick webp related failures.

This fixes #48018, as suggested by Saku Laesvuori on the issue tracker.

* gnu/packages/imagemagick.scm (imagemagick/stable)[inputs]: Add libwebp.

Change-Id: I3c02d0fb6c421f7d865b19af359e20068d00b60a
---
 gnu/packages/imagemagick.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/imagemagick.scm b/gnu/packages/imagemagick.scm
index b407af3588..ac366a378b 100644
--- a/gnu/packages/imagemagick.scm
+++ b/gnu/packages/imagemagick.scm
@@ -124,6 +124,7 @@ (define-public imagemagick/stable
                ("libtiff" ,libtiff)
                ("libpng" ,libpng)
                ("libjpeg" ,libjpeg-turbo)
+               ("libwebp" ,libwebp)
                ("pango" ,pango)
                ("freetype" ,freetype)
                ("bzip2" ,bzip2)

base-commit: d52ee267ee8245a6edfcd137c73d20b036ec08d1
-- 
2.41.0

bug#48018: reviewed, checked and re-based the previous commit

[Maxim Cournoyer]

Hi,

"Wicki Gabriel (wicg)" <wicg@zhaw.ch> writes:

> I've checked the patch above which works like a charm.  I've created a
> new patch.  Please credit the original author before merging.

I've applied it on core-updates, as imagemagick causes a large number of
rebuilds.

-- 
Thanks,
Maxim

bug#48018: ImageMagick’s ‘convert’ fails to delegate to ‘dwebp’

[Simon South]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> I've applied it on core-updates, as imagemagick causes a large number
> of rebuilds.

Unfortunately a small bug crept in with commit 62d1806f42: ",name" needs
to be changed to "$name" or building ImageMagick fails with

unquote: expression not valid outside of quasiquote in form (unquote name)

-- 
Simon South
simon@simonsouth.net

bug#48018: ImageMagick’s ‘convert’ fails to delegate to ‘dwebp’

[Maxim Cournoyer]

Hi,

Simon South <simon@simonsouth.net> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>> I've applied it on core-updates, as imagemagick causes a large number
>> of rebuilds.
>
> Unfortunately a small bug crept in with commit 62d1806f42: ",name" needs
> to be changed to "$name" or building ImageMagick fails with
>
> unquote: expression not valid outside of quasiquote in form (unquote name)

Thanks for the heads-up.  That's now fixed.  Apologies for sloppy QA
:-).

-- 
Thanks,
Maxim