unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: 29700-done@debbugs.gnu.org
Subject: bug#29700: Java packages need to retain references
Date: Thu, 14 Dec 2017 23:59:22 +0100	[thread overview]
Message-ID: <87mv2kvrud.fsf@elephly.net> (raw)
In-Reply-To: <87tvwuutvr.fsf@elephly.net>

Hi Gábor,

The manifest file would not be sufficient.  Take the example of
“java-usb4java”.  It provides a file “share/java/usb4java.jar”, which
contains this manifest:

--8<---------------cut here---------------start------------->8---
Manifest-Version: 1.0
Created-By: 1.7.0_161 (Oracle Corporation)

--8<---------------cut here---------------end--------------->8---

When you open the Loader.class file that is included in the archive you
will notice that it contains this string:

    /gnu/store/iwjqaqr98daqbgwswqi5fi4w891bqh7d-libusb4java-0-1.396d642a5/lib/libusb4java.so

This reference is currently dropped because it cannot be detected in a
compressed archive.  The reference is not contained in the manifest, and
at build time we could only guess which references should be added to
the manifest.

Unless we extend the reference scanner to deal with compressed files I
think that disabling compression in jars is the best approach.

I’ll push this to master.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  parent reply	other threads:[~2017-12-14 23:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 22:48 bug#29700: Java packages need to retain references Ricardo Wurmus
2017-12-13 23:09 ` bug#29700: [PATCH] guix: ant-build-system: Do not compress jars Ricardo Wurmus
2017-12-14  8:23   ` Danny Milosavljevic
2017-12-14 22:59 ` Ricardo Wurmus [this message]
2017-12-15  6:44   ` bug#29700: Java packages need to retain references Gábor Boskovits
2017-12-15  7:49     ` Ricardo Wurmus
2017-12-15 14:55 ` Ludovic Courtès
  -- strict thread matches above, loose matches on Subject: below --
2017-12-13 22:28 bug#29705: " Ricardo Wurmus
2017-12-14  7:07 ` Gábor Boskovits
2017-12-14 22:22   ` bug#29700: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv2kvrud.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=29700-done@debbugs.gnu.org \
    --cc=boskovits@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).