From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#29700: Java packages need to retain references Date: Thu, 14 Dec 2017 23:59:22 +0100 Message-ID: <87mv2kvrud.fsf@elephly.net> References: <87tvwuutvr.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePdDW-0005xZ-J9 for bug-guix@gnu.org; Thu, 14 Dec 2017 18:47:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePdDT-0005e6-Gx for bug-guix@gnu.org; Thu, 14 Dec 2017 18:47:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePdDT-0005d9-1O for bug-guix@gnu.org; Thu, 14 Dec 2017 18:47:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePdDS-0004q1-LP for bug-guix@gnu.org; Thu, 14 Dec 2017 18:47:02 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-reply-to: <87tvwuutvr.fsf@elephly.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 29700-done@debbugs.gnu.org Hi G=C3=A1bor, The manifest file would not be sufficient. Take the example of =E2=80=9Cjava-usb4java=E2=80=9D. It provides a file =E2=80=9Cshare/java/us= b4java.jar=E2=80=9D, which contains this manifest: --8<---------------cut here---------------start------------->8--- Manifest-Version: 1.0 Created-By: 1.7.0_161 (Oracle Corporation) --8<---------------cut here---------------end--------------->8--- When you open the Loader.class file that is included in the archive you will notice that it contains this string: /gnu/store/iwjqaqr98daqbgwswqi5fi4w891bqh7d-libusb4java-0-1.396d642a5/l= ib/libusb4java.so This reference is currently dropped because it cannot be detected in a compressed archive. The reference is not contained in the manifest, and at build time we could only guess which references should be added to the manifest. Unless we extend the reference scanner to deal with compressed files I think that disabling compression in jars is the best approach. I=E2=80=99ll push this to master. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net