From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 64593@debbugs.gnu.org, Yann Dupont <yann.dupont@univ-nantes.fr>,
Sergey Trofimov <sarg@sarg.org.ru>
Subject: bug#64593: ‘guix system image’ fails to create image while invoking ‘grub-bios-setup’
Date: Mon, 17 Jul 2023 18:11:44 +0200 [thread overview]
Message-ID: <87mszuplfj.fsf@inria.fr> (raw)
In-Reply-To: <87351of71j.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sun, 16 Jul 2023 13:08:08 +0200")
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hi Josselin,
Josselin Poiret <dev@jpoiret.xyz> skribis:
> Ludovic Courtès <ludovic.courtes@inria.fr> writes:
>
>> The culprit might be 209204e23b39af09e0ea92540b6fa00a60e6a0ae, from
>> <https://issues.guix.gnu.org/62223>.
>>
>> Josselin, Sergey, WDYT?
>
> Apologies! Our install-grub-disk-image doesn't really support GPT
> right, now but this is easy to fix (I've successfully booted your
> example with a local change). However, for this to work we need to have
> a BIOS Boot partition instead of the ESP that's defined for efi images.
> We have two options here, either add a new image type that has that
> instead of the ESP (which means duplicating a bunch of them...), or make
> the partition of efi-raw change depending on the bootloader, which would
> need some refactoring. I'm not a big fan of either options though :)
I’m not sure what a good fix is, but I think we should make sure ‘guix
system image’ (‘-t efi-raw’, that is) doesn’t remain broken.
One possible short-term option is to revert, or maybe we could
special-case along these lines:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 664 bytes --]
diff --git a/gnu/system/image.scm b/gnu/system/image.scm
index 841e7e0c7e..b4ed4181ac 100644
--- a/gnu/system/image.scm
+++ b/gnu/system/image.scm
@@ -204,7 +204,12 @@ (define-syntax-rule (image-with-os base-image os)
(define efi-raw-image-type
(image-type
(name 'efi-raw)
- (constructor (cut image-with-os efi-disk-image <>))))
+ (constructor (cut image-with-os
+ (image-without-os
+ (format 'disk-image)
+ (partition-table-type 'mbr) ;XXX
+ (partitions (list esp-partition root-partition)))
+ <>))))
(define efi32-raw-image-type
(image-type
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
WDYT?
Ludo’.
next prev parent reply other threads:[~2023-07-17 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:33 bug#64593: ‘guix system image’ fails to create image while invoking ‘grub-bios-setup’ Ludovic Courtès
2023-07-16 11:08 ` Josselin Poiret via Bug reports for GNU Guix
2023-07-17 16:11 ` Ludovic Courtès [this message]
2023-07-27 16:35 ` bug#64593: [PATCH] image: Add mbr-raw-image-type and use by default Josselin Poiret via Bug reports for GNU Guix
2023-07-27 17:47 ` Nicolas Graves via Bug reports for GNU Guix
2023-08-07 7:39 ` bug#64593: ‘guix system image’ fails to create image while invoking ‘grub-bios-setup’ Ludovic Courtès
2023-07-18 18:34 ` Sergey Trofimov
2023-07-19 8:43 ` Josselin Poiret via Bug reports for GNU Guix
2023-08-07 7:35 ` Ludovic Courtès
2023-08-08 9:02 ` Josselin Poiret via Bug reports for GNU Guix
2023-08-25 16:33 ` Josselin Poiret via Bug reports for GNU Guix
2023-07-21 7:43 ` Yann Dupont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mszuplfj.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=64593@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=sarg@sarg.org.ru \
--cc=yann.dupont@univ-nantes.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).