From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UI2RE3JotWQZHwAASxT56A (envelope-from ) for ; Mon, 17 Jul 2023 18:12:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +JSgE3JotWRYMwEAauVa8A (envelope-from ) for ; Mon, 17 Jul 2023 18:12:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 001FD3FFA1 for ; Mon, 17 Jul 2023 18:12:34 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=aPdARWI6; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689610354; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=B804ao32o9YNjOzXYLIZn4I5F7mMuhCmGUCmpmTUdD8=; b=Z7yTNfaZRmbV8Z3xJC4bR2uqh2Dv7VOjQDANN9DZffgRyB9zfnAlc61ZBH8FDwhhdsJ0bf dJWfgQoy21VyTw19qxVgz6lXSU5p5WbFHPgcOxrs58uF51y/FvwBKuKrf8IVsrKSD35wBM yWtCnSOmJDmzm++PZXGvrD9kfs6r+uiQJEwO+OEDKabYXo1+Pjs/JB/WgjWXDtzGn5dlIU 4sv27+olfwX8lxNimiLxcZIwojPyOdIMTymDo56RftwswAd4dWSt/QYJItgfGSJ7LnmwEw CRwBa1BrJDBjqnxjX9YD/SKdfCnqxZp+5uBXhf/oIkSx3vDuVjMhdmjna/DmVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689610354; a=rsa-sha256; cv=none; b=bi7g/Ioo4LA/qB9JWGhdQQRI3K5NI/A58vDd+Widt3A1glXu9RtTc/+aqvfPBbaoOnrhrN J8/Tg6v+WRV/gLdbsuPn6ppU4/kBHYn8jIbSJmABe6A4OjEfJw9NvBdOdR6fW9m4Hwai/v uY9YyJ3gE+8LaDGHU4dg8cMnCax5bF4Vloi6rNjnOu66U3CTwIkT1YI06fKXYPjMyXF/D6 HKv5WreWd/E9WpfG+atcvtu83Xuyry8+cL/3MgXQgDWu9/A0AFINDSq53ny+kzy7/AX/u9 1E+d+WjoWE+slXJJKoEAXEbVSdtcG/yBHcP7Nv8nqSd8oiomWiqB+as9abiLMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=aPdARWI6; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLQpb-0005vr-RO; Mon, 17 Jul 2023 12:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQpO-0005uP-J6 for bug-guix@gnu.org; Mon, 17 Jul 2023 12:12:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLQpO-0005oT-B4 for bug-guix@gnu.org; Mon, 17 Jul 2023 12:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLQpO-0001QW-6Y for bug-guix@gnu.org; Mon, 17 Jul 2023 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#64593: =?UTF-8?Q?=E2=80=98guix?= system =?UTF-8?Q?image=E2=80=99?= fails to create image while invoking =?UTF-8?Q?=E2=80=98grub-bios-setup=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 17 Jul 2023 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64593 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Josselin Poiret Cc: 64593@debbugs.gnu.org, Yann Dupont , Sergey Trofimov Received: via spool by 64593-submit@debbugs.gnu.org id=B64593.16896103155471 (code B ref 64593); Mon, 17 Jul 2023 16:12:02 +0000 Received: (at 64593) by debbugs.gnu.org; 17 Jul 2023 16:11:55 +0000 Received: from localhost ([127.0.0.1]:50802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQpG-0001QA-QS for submit@debbugs.gnu.org; Mon, 17 Jul 2023 12:11:55 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:20153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQpD-0001Pw-TE for 64593@debbugs.gnu.org; Mon, 17 Jul 2023 12:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=B804ao32o9YNjOzXYLIZn4I5F7mMuhCmGUCmpmTUdD8=; b=aPdARWI6MXp6LaA/+qRBqHpRGEPLMy+NiAtzHZTnQs54kURLGkmWnBrS qNzvZQYkUWf+P83l5iV6u7BQI8pZZWrnMo+rgwvCftq2L9Cdodck4HplL yQTq95dBHm6gakpkiX0thG74euAXU/CPuCfv3LR7Qy2TDLg1cMy1uIdQT E=; X-IronPort-AV: E=Sophos;i="6.01,211,1684792800"; d="scan'208";a="61576326" Received: from unknown (HELO ribbon) ([193.50.110.205]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 18:11:46 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sf9syx3m.fsf@inria.fr> <87351of71j.fsf@jpoiret.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 29 Messidor an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du =?UTF-8?Q?Bl=C3=A9?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Jul 2023 18:11:44 +0200 In-Reply-To: <87351of71j.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sun, 16 Jul 2023 13:08:08 +0200") Message-ID: <87mszuplfj.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.96 X-Spam-Score: -4.96 X-Migadu-Queue-Id: 001FD3FFA1 X-Migadu-Scanner: mx1.migadu.com X-TUID: 0+cng9S2dI8L --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Josselin, Josselin Poiret skribis: > Ludovic Court=C3=A8s writes: > >> The culprit might be 209204e23b39af09e0ea92540b6fa00a60e6a0ae, from >> . >> >> Josselin, Sergey, WDYT? > > Apologies! Our install-grub-disk-image doesn't really support GPT > right, now but this is easy to fix (I've successfully booted your > example with a local change). However, for this to work we need to have > a BIOS Boot partition instead of the ESP that's defined for efi images. > We have two options here, either add a new image type that has that > instead of the ESP (which means duplicating a bunch of them...), or make > the partition of efi-raw change depending on the bootloader, which would > need some refactoring. I'm not a big fan of either options though :) I=E2=80=99m not sure what a good fix is, but I think we should make sure = =E2=80=98guix system image=E2=80=99 (=E2=80=98-t efi-raw=E2=80=99, that is) doesn=E2=80= =99t remain broken. One possible short-term option is to revert, or maybe we could special-case along these lines: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 841e7e0c7e..b4ed4181ac 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -204,7 +204,12 @@ (define-syntax-rule (image-with-os base-image os) (define efi-raw-image-type (image-type (name 'efi-raw) - (constructor (cut image-with-os efi-disk-image <>)))) + (constructor (cut image-with-os + (image-without-os + (format 'disk-image) + (partition-table-type 'mbr) ;XXX + (partitions (list esp-partition root-partition))) + <>)))) (define efi32-raw-image-type (image-type --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQpXRFlUPw0KDQpMdWRv4oCZLg0K --=-=-=--