From: George Clemmer <myglc2@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31786@debbugs.gnu.org
Subject: bug#31786: 'pre-inst-env guix --version' is not updated by new commits"
Date: Tue, 12 Jun 2018 14:28:43 -0400 [thread overview]
Message-ID: <87k1r3271g.fsf@gmail.com> (raw)
In-Reply-To: <87k1r4p2ca.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Hello George,
>
> George Clemmer <myglc2@gmail.com> skribis:
>
>> But with subsequent git commit/make cycles the version does not
>> change. It doesn't change when the guix package is updated either. For
>> example, after pulling and building the recent commit updating the guix
>> package ...
>
> Currently the version number is hardcoded in ‘configure.ac’, so the fact
> that running “git pull && make” doesn’t change it is expected. So to
> me, it’s not a bug.
>
> We could improve on that (see for instance how Guile does it with
> build-aux/git-version-gen), but it still won’t be updated at each commit
> because that’d be inconvenient: ‘config.h’ would regenerated, so in turn
> we’d need to rebuild all of the C++ code.
Hi Ludo’,
Ok, cool. Thanks for the clarification. So... how about adding a
footnote to '(guix) Running Guix Before It Is Installed' something like
...
(3) The Guix version in the Guix build is set by './configure'. Thus,
when guix is run from the Git working tree by './pre-inst-env guix' or a
'~/.config/guix/latest’ symlink, the version reported by 'guix
--version' is not updated by subsequent 'git pull; make' steps. To
update the version (and rebuild everything), you may use 'git clean
-dfx; ./bootstrap; ./configure; make'.
Note: I also tried 'make distclean' and 'make maintainer-clean' which
didn't work.
> ‘guix pull’ does the right thing though, which I think is more important
> than the build tree.
Agreed.
>> Side questions:
>>
>> 1) why don't you gitignore "doc/stamp-1"?
>
> Good idea, done! :-)
Thanks!
>> 2) why don't you gitignore .po files?
>
> Because they are checked in.
I guess I meant to say, why does the build change these checked-in
files? It seems like they should be ignored.
TIA - George
next prev parent reply other threads:[~2018-06-12 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 18:01 bug#31786: 'pre-inst-env guix --version' is not updated by new commits" George Clemmer
2018-06-12 13:21 ` Ludovic Courtès
2018-06-12 18:28 ` George Clemmer [this message]
2018-06-12 20:33 ` Ludovic Courtès
2018-06-13 0:51 ` George Clemmer
2018-06-13 6:54 ` Ludovic Courtès
2018-06-14 1:39 ` Leo Famulari
2018-06-14 15:18 ` George Clemmer
2018-06-14 16:10 ` Clément Lassieur
2018-06-14 16:45 ` Clément Lassieur
2018-06-14 16:36 ` Ludovic Courtès
2018-06-15 19:13 ` George Clemmer
2018-06-15 20:30 ` Nils Gillmann
2018-06-16 16:06 ` George Clemmer
2018-06-15 22:02 ` Ricardo Wurmus
2018-06-15 22:24 ` Ricardo Wurmus
2018-06-19 16:47 ` myglc2
2018-06-16 1:35 ` George Clemmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1r3271g.fsf@gmail.com \
--to=myglc2@gmail.com \
--cc=31786@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).