From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Clemmer Subject: bug#31786: 'pre-inst-env guix --version' is not updated by new commits" Date: Tue, 12 Jun 2018 14:28:43 -0400 Message-ID: <87k1r3271g.fsf@gmail.com> References: <87r2lddwyg.fsf@gmail.com> <87k1r4p2ca.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSo2V-00010a-ME for bug-guix@gnu.org; Tue, 12 Jun 2018 14:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSo2Q-0004A4-NL for bug-guix@gnu.org; Tue, 12 Jun 2018 14:29:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSo2Q-00049z-Io for bug-guix@gnu.org; Tue, 12 Jun 2018 14:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSo2Q-0007JW-Bh for bug-guix@gnu.org; Tue, 12 Jun 2018 14:29:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87k1r4p2ca.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31786@debbugs.gnu.org Ludovic Courtès writes: > Hello George, > > George Clemmer skribis: > >> But with subsequent git commit/make cycles the version does not >> change. It doesn't change when the guix package is updated either. For >> example, after pulling and building the recent commit updating the guix >> package ... > > Currently the version number is hardcoded in ‘configure.ac’, so the fact > that running “git pull && make” doesn’t change it is expected. So to > me, it’s not a bug. > > We could improve on that (see for instance how Guile does it with > build-aux/git-version-gen), but it still won’t be updated at each commit > because that’d be inconvenient: ‘config.h’ would regenerated, so in turn > we’d need to rebuild all of the C++ code. Hi Ludo’, Ok, cool. Thanks for the clarification. So... how about adding a footnote to '(guix) Running Guix Before It Is Installed' something like ... (3) The Guix version in the Guix build is set by './configure'. Thus, when guix is run from the Git working tree by './pre-inst-env guix' or a '~/.config/guix/latest’ symlink, the version reported by 'guix --version' is not updated by subsequent 'git pull; make' steps. To update the version (and rebuild everything), you may use 'git clean -dfx; ./bootstrap; ./configure; make'. Note: I also tried 'make distclean' and 'make maintainer-clean' which didn't work. > ‘guix pull’ does the right thing though, which I think is more important > than the build tree. Agreed. >> Side questions: >> >> 1) why don't you gitignore "doc/stamp-1"? > > Good idea, done! :-) Thanks! >> 2) why don't you gitignore .po files? > > Because they are checked in. I guess I meant to say, why does the build change these checked-in files? It seems like they should be ignored. TIA - George