unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: 19973-done@debbugs.gnu.org
Subject: bug#19973: Grafts break debug outputs
Date: Fri, 24 Aug 2018 18:08:38 +0200	[thread overview]
Message-ID: <87k1oflpbt.fsf@gnu.org> (raw)
In-Reply-To: <87pnybmoey.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 21 Aug 2018 22:53:57 +0200")

Hello,

ludo@gnu.org (Ludovic Courtès) skribis:

> The patches below address this by adding code to update the CRC in the
> ‘.gnu_debuglink’ section upon grafting.  It uses a simple hook
> mechanism, a simplified version of what Timothy proposed.
>
> The ‘.gnu_debuglink’ hook does nothing for packages that lack a “debug”
> output.  For packages that have a “debug” output, only ELF files from
> bin/, lib/, etc. are considered.  Overall the run-time cost should be
> low.

I went ahead and pushed these two patches as
93c333895a4e2dc9baabec8ade60d9d2ac0a91e2 and
e4297aa8b95cefa32e2595ce58886fc03b0561f7.

I modified tests/debug-link.scm compared to what I posted such that it
would skip tests that require %bootstrap-gcc when networking is lacking.

Thanks for your feedback,
Ludo’.

      parent reply	other threads:[~2018-08-24 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01  5:06 bug#19973: Grafts break debug outputs Mark H Weaver
2015-03-01  5:24 ` Mark H Weaver
2017-03-07 21:54 ` Ludovic Courtès
2017-03-10 13:14   ` Ludovic Courtès
2018-08-21 20:53   ` Ludovic Courtès
2018-08-21 20:56     ` bug#19973: [PATCH 1/2] grafts: Add high-level 'graft' procedure on the build side Ludovic Courtès
2018-08-21 20:56       ` bug#19973: [PATCH 2/2] grafts: Add (guix build debug-link) and use it Ludovic Courtès
2018-08-22 14:04     ` bug#19973: Grafts break debug outputs Timothy Sample
2018-08-23 15:47       ` Ludovic Courtès
2018-08-24 16:08     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1oflpbt.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=19973-done@debbugs.gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).