From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#19973: Grafts break debug outputs
Date: Fri, 24 Aug 2018 18:08:38 +0200
Message-ID: <87k1oflpbt.fsf@gnu.org>
References: <878ufh71do.fsf@netris.org> <87a88wrbvk.fsf@gnu.org>
	<87pnybmoey.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ftEe3-0003Ao-9G
	for bug-guix@gnu.org; Fri, 24 Aug 2018 12:09:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ftEdy-0003nh-Ig
	for bug-guix@gnu.org; Fri, 24 Aug 2018 12:09:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54889)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ftEdy-0003nG-6k
	for bug-guix@gnu.org; Fri, 24 Aug 2018 12:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ftEdx-00031k-Uz
	for bug-guix@gnu.org; Fri, 24 Aug 2018 12:09:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.19973.D19973.153512693711621.done@debbugs.gnu.org>
In-Reply-To: <87pnybmoey.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Tue, 21 Aug 2018 22:53:57 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 19973-done@debbugs.gnu.org

Hello,

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> The patches below address this by adding code to update the CRC in the
> =E2=80=98.gnu_debuglink=E2=80=99 section upon grafting.  It uses a simple=
 hook
> mechanism, a simplified version of what Timothy proposed.
>
> The =E2=80=98.gnu_debuglink=E2=80=99 hook does nothing for packages that =
lack a =E2=80=9Cdebug=E2=80=9D
> output.  For packages that have a =E2=80=9Cdebug=E2=80=9D output, only EL=
F files from
> bin/, lib/, etc. are considered.  Overall the run-time cost should be
> low.

I went ahead and pushed these two patches as
93c333895a4e2dc9baabec8ade60d9d2ac0a91e2 and
e4297aa8b95cefa32e2595ce58886fc03b0561f7.

I modified tests/debug-link.scm compared to what I posted such that it
would skip tests that require %bootstrap-gcc when networking is lacking.

Thanks for your feedback,
Ludo=E2=80=99.