From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Carl Dong <contact@carldong.me>
Cc: 34170@debbugs.gnu.org,
Danny Milosavljevic <dannym@scratchpost.org>,
Maxime Devos <maximedevos@telenet.be>,
zimoun <zimon.toutoune@gmail.com>
Subject: bug#34170: bitcoin-core bundles leveldb
Date: Wed, 13 Jul 2022 11:10:42 -0400 [thread overview]
Message-ID: <87k08hyrnx.fsf@gmail.com> (raw)
In-Reply-To: <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@carldong.me> (Carl Dong's message of "Thu, 6 Jan 2022 19:17:13 -0500")
Hi Carl,
Carl Dong <contact@carldong.me> writes:
>> If desired, it would also be possible to do something in-between
>> unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin'
>> variant of the 'leveldb' package (using package/inherit or (package
>> (inherit ...) ...)), add it as input to the 'bitcoin' package and tell
>> and/or patch bitcoin's buid scripts to use that leveldb.
> Yes I think that would be a splendid idea! With regards to patching
> bitcoin’s builds scripts, Bitcoin Knots follows Bitcoin Core closely,
> but has a bunch of patches which allow for using system libs, so that
> might be good to reference:
> https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-syslibs
> <https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-syslibs>
>
>> As source code, use an appropriate commit from
>> <https://github.com/bitcoin-core/leveldb-subtree> (and add a comment
>> to the definition of bitcoin-core to keep leveldb/bitcoin in-sync).
>
> FYI, according to https://github.com/bitcoin/bitcoin/pull/17398
> <https://github.com/bitcoin/bitcoin/pull/17398>, we are currently
> using the upstream LevelDB commit
> 0c40829872a9f00f38e11dc370ff8adb3e19f25b
Would you like to give the idea discussed above a try and send a patch?
That'd bring closure to this old issue :-).
Thanks,
Maxim
prev parent reply other threads:[~2022-07-13 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 12:31 bug#34170: bitcoin-core bundles leveldb Danny Milosavljevic
2021-12-03 10:29 ` zimoun
2022-01-04 23:29 ` zimoun
2022-01-05 9:39 ` Maxime Devos
2022-01-05 9:45 ` zimoun
2022-01-05 17:40 ` Carl Dong
2022-01-05 19:13 ` Maxime Devos
2022-01-07 0:17 ` Carl Dong
2022-07-13 15:10 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k08hyrnx.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=34170@debbugs.gnu.org \
--cc=contact@carldong.me \
--cc=dannym@scratchpost.org \
--cc=maximedevos@telenet.be \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).