unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>,
	Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34170@debbugs.gnu.org, contact@carldong.me
Subject: bug#34170: bitcoin-core bundles leveldb
Date: Wed, 05 Jan 2022 10:39:19 +0100	[thread overview]
Message-ID: <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@telenet.be> (raw)
In-Reply-To: <865ys6m168.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

zimoun schreef op vr 03-12-2021 om 11:29 [+0100]:
> Hi,
> 
> This old bug#34170 [1] provides only the ’Subject’ as elements.
> The package bitcore-core still provides ’leveldb’:
> 
> [...]
> 
> and I am not sure to get what is the issue.  Some explanations?

The issue is that bitcoin-core bundles leveldb (which you have shown
is still the case), even though leveldb is packaged in Guix. See, e.g.
‘(guix)Snippets versus Phases’ and the following from ‘(guix)Submitting
Patches’:

  7. Make sure the package does not use bundled copies of software
     already available as separate packages.

     Sometimes, packages include copies of the source code of their
     dependencies as a convenience for users.  However, as a
     distribution, we want to make sure that such packages end up using
     the copy we already have in the distribution, if there is one.
     This improves resource usage (the dependency is built and stored
     only once), and allows the distribution to make transverse changes
     such as applying security updates for a given software package in a
     single place and have them affect the whole system—something that
     bundled copies prevent.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-01-05  9:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 12:31 bug#34170: bitcoin-core bundles leveldb Danny Milosavljevic
2021-12-03 10:29 ` zimoun
2022-01-04 23:29   ` zimoun
2022-01-05  9:39   ` Maxime Devos [this message]
2022-01-05  9:45     ` zimoun
2022-01-05 17:40       ` Carl Dong
2022-01-05 19:13         ` Maxime Devos
2022-01-07  0:17           ` Carl Dong
2022-07-13 15:10             ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=34170@debbugs.gnu.org \
    --cc=contact@carldong.me \
    --cc=dannym@scratchpost.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).